Re: [Cocci] coccinelle: api: add sprintf() support to device_attr_show

[Julia Lawall <julia.lawall@inria.fr>]

[-- Attachment #1: Type: text/plain, Size: 1421 bytes --]



On Sat, 5 Sep 2020, Markus Elfring wrote:

> > The clarification will be continued when you provide a small semantic
> > patch and a C file that causes a problem.
>
> I imagine that a patch review was still running.
>
>
> > I'm not going to hunt in years
>
> This action is not needed here.
>
>
> > of mail archives to find it.
>
> Have you got ongoing difficulties with safe issue tracking?
>
> Please use the information also from available archive interfaces.
> https://lore.kernel.org/cocci/0a9015b6-9037-59c5-31f2-cd2b32c86b50@linux.com/
> https://systeme.lip6.fr/pipermail/cocci/2020-August/008120.html
>
>
> > If you want something to happen you have to provide that information now.
>
> Would you like to test the software any further with the attached SmPL script variant
> (and the previously mentioned Linux source file “drivers/base/core.c” for example)?

It doesn't work because you persist in thinking that you can put a
disjunction around anything.  This is not correct.  You can only put
disjuctions around expressions, statements, types, etc.  But not fragments
of an expression list.  You have

\(str\|huge_regexp,...\)

This is matched against a single expression, which can either be str or a
comma expression consisting of something that matches your huge regular
expression followed by another expression.

There is no problem here.  There will be no changes with respect to this
issue.

julia

[-- Attachment #2: Type: text/plain, Size: 136 bytes --]

_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci