Coccinelle Archive on lore.kernel.org
 help / color / Atom feed
From: Julia Lawall <julia.lawall@inria.fr>
To: Denis Efremov <efremov@linux.com>
Cc: cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org
Subject: Re: [Cocci] kzfree script
Date: Fri, 2 Oct 2020 16:13:49 +0200 (CEST)
Message-ID: <alpine.DEB.2.22.394.2010021612200.2707@hadrien> (raw)
In-Reply-To: <7bf57afe-43d6-1288-cd8b-951079a35fa9@linux.com>



On Fri, 2 Oct 2020, Denis Efremov wrote:

> Hi,
>
> On 10/2/20 5:01 PM, Julia Lawall wrote:
> > Denis,
> >
> > In the rule proposing kzfree_sensitive, I think it would be helpful to
> > also highlight the memset line.
>
> What do you mean? It's "highlighted" in context mode. Do you mean adding
> position argument to memset call and showing this position in the warning
> messages?

Yes, that seems to be what I mean.  0-day generated a message from the
script, and I had to hunt around for the reason why it was doing that.  So
it would be nice to have the memset highlighted.  It seems that the
non-patch 0-day messages are generated from the report mode.

thanks,
julia
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

  reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-02 14:01 Julia Lawall
2020-10-02 14:10 ` Denis Efremov
2020-10-02 14:13   ` Julia Lawall [this message]
2020-10-02 14:15     ` Denis Efremov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.22.394.2010021612200.2707@hadrien \
    --to=julia.lawall@inria.fr \
    --cc=cocci@systeme.lip6.fr \
    --cc=efremov@linux.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Coccinelle Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/cocci/0 cocci/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 cocci cocci/ https://lore.kernel.org/cocci \
		cocci@systeme.lip6.fr
	public-inbox-index cocci

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/fr.lip6.systeme.cocci


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git