From: Julia Lawall <julia.lawall@inria.fr>
To: Sumera Priyadarsini <sylphrenadin@gmail.com>
Cc: michal.lkml@markovi.net, linux-doc@vger.kernel.org,
Gilles.Muller@lip6.fr, corbet@lwn.net, nicolas.palix@imag.fr,
linux-kernel@vger.kernel.org, Julia.Lawall@lip6.fr,
cocci@systeme.lip6.fr
Subject: Re: [Cocci] [PATCH v4 2/3] scripts: coccicheck: Change default condition for parallelism
Date: Mon, 12 Oct 2020 10:38:14 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2010121038040.2901@hadrien> (raw)
In-Reply-To: <13de95fe3959459ac9ae8c74d99eb7e3c5702a2d.1602410019.git.sylphrenadin@gmail.com>
On Sun, 11 Oct 2020, Sumera Priyadarsini wrote:
> Currently, Coccinelle uses at most one thread per core by default in
> machines with more than 2 hyperthreads. However, for systems with only 4
> hyperthreads, this does not improve performance.
>
> Modify coccicheck to use all available threads in machines with
> upto 4 hyperthreads.
>
> Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
Applied, thanks.
> ---
> scripts/coccicheck | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/coccicheck b/scripts/coccicheck
> index d67907b8a38b..209bb0427b43 100755
> --- a/scripts/coccicheck
> +++ b/scripts/coccicheck
> @@ -79,7 +79,7 @@ else
> THREADS_PER_CORE=$(lscpu | grep "Thread(s) per core: " | tr -cd "[:digit:]")
> if [ -z "$J" ]; then
> NPROC=$(getconf _NPROCESSORS_ONLN)
> - if [ $THREADS_PER_CORE -gt 1 -a $NPROC -gt 2 ] ; then
> + if [ $THREADS_PER_CORE -gt 1 -a $NPROC -gt 4 ] ; then
> NPROC=$((NPROC/2))
> fi
> else
> --
> 2.25.1
>
> _______________________________________________
> Cocci mailing list
> Cocci@systeme.lip6.fr
> https://systeme.lip6.fr/mailman/listinfo/cocci
>
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
next prev parent reply other threads:[~2020-10-12 8:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-11 10:26 [Cocci] [PATCH v4 0/3] Improve Coccinelle Parallelisation Sumera Priyadarsini
2020-10-11 10:28 ` [Cocci] [PATCH v4 1/3] scripts: coccicheck: Add quotes to improve portability Sumera Priyadarsini
2020-10-12 8:38 ` Julia Lawall
2020-10-11 10:29 ` [Cocci] [PATCH v4 2/3] scripts: coccicheck: Change default condition for parallelism Sumera Priyadarsini
2020-10-12 8:38 ` Julia Lawall [this message]
2020-10-11 10:31 ` [Cocci] [PATCH v4 3/3] Documentation: Coccinelle: Modify Parallelisation information in docs Sumera Priyadarsini
2020-10-12 8:39 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2010121038040.2901@hadrien \
--to=julia.lawall@inria.fr \
--cc=Gilles.Muller@lip6.fr \
--cc=Julia.Lawall@lip6.fr \
--cc=cocci@systeme.lip6.fr \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
--cc=sylphrenadin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).