From: Julia Lawall <julia.lawall@inria.fr>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: cocci@systeme.lip6.fr
Subject: Re: [Cocci] Adjusting replacement lists with SmPL?
Date: Fri, 23 Oct 2020 17:11:00 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2010231710010.2707@hadrien> (raw)
In-Reply-To: <13dbaaf7-6655-7939-e173-310c45d1878e@web.de>
[-- Attachment #1: Type: text/plain, Size: 1629 bytes --]
On Fri, 23 Oct 2020, Markus Elfring wrote:
> > I'd like to add a statement after another within a preprocessor expression,
> >
> > How do you think about to refer to a “#define directive”?
> >
> >
> > > but spatch adds the line without an escape (backslash).
> >
> > I imagine that we stumble on another target conflict here.
> > https://github.com/coccinelle/coccinelle/issues/139
> >
> > Do you really want to adjust a bit of text according to a preprocessing
> > definition?
> >
> >
> > > #define X(a) x(a);
> > >
> > > (I know the above is not technically correct but it's super common.)
> >
> > I stumble on understanding difficulties for this information.
> > Would you like to clarify the knowledge about correctness a bit more?
> >
> >
> > > @@
> > > expression e;
> > > @@
> > > x(e);
> > > + y(e);
> >
> > How should the scope be specified that a change should be performed
> > only for preprocessor code (replacement lists for your transformation
> > approach)?
I don't think he is asking that. He means, if the call to x happens to be
in a macro definition, how can he ensure that the transformed code treats
newlines in the right way.
julia
> >
> >
> > > I can think of two solutions, if an expression is inside a
> > > preprocessor statement: add a backslash before every newline, or skip
> > > the newline.
> >
> > Would you like to choose the preferred coding style for such an use case?
> >
> > Regards,
> > Markus
> > _______________________________________________
> > Cocci mailing list
> > Cocci@systeme.lip6.fr
> > https://systeme.lip6.fr/mailman/listinfo/cocci
> >
[-- Attachment #2: Type: text/plain, Size: 136 bytes --]
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
next prev parent reply other threads:[~2020-10-23 15:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 3:33 [Cocci] Newline escape in preprocessor Mansour Moufid
2020-10-23 6:05 ` Julia Lawall
2020-10-23 15:00 ` [Cocci] Adjusting replacement lists with SmPL? Markus Elfring
2020-10-23 15:11 ` Julia Lawall [this message]
2020-10-25 2:04 ` Mansour Moufid
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2010231710010.2707@hadrien \
--to=julia.lawall@inria.fr \
--cc=Markus.Elfring@web.de \
--cc=cocci@systeme.lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).