Coccinelle Archive on lore.kernel.org
 help / color / Atom feed
From: Julia Lawall <julia.lawall@inria.fr>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Coccinelle <cocci@systeme.lip6.fr>
Subject: Re: [Cocci] Adjusting some calls according to pass-through functions
Date: Sun, 29 Nov 2020 13:52:29 +0100 (CET)
Message-ID: <alpine.DEB.2.22.394.2011291351210.2671@hadrien> (raw)
In-Reply-To: <978f08c3-21ed-d434-d2ef-163335ae990e@web.de>


[-- Attachment #1: Type: text/plain, Size: 1314 bytes --]



On Sun, 29 Nov 2020, Markus Elfring wrote:

> > A rule for each of the functions you have in the big disjunction
> > you have on the first line of your rule.
>
> I find that the size of such SmPL disjunctions can grow considerably.
>
>
> > But it only helps in your case because in your C code,
> > the first two lines have different function names.
>
> This would be usual for the C programming language.
> Would you ever like to consider additional development challenges for C++
> where distinctions would be more relevant for data types on input parameters?

I don't see any connection between your comment and what I said.  I think
that in both C and C++, people may call the same function on two
subsequent lines.

>
>
> >> Two changes should be performed in combination for a code replacement.
> >> How should a separation help then?
> >>
> >> Can the shown change pattern be applied recursively?
> >
> > You can follow the example in demos/iteration.cocci.
>
> Does a corresponding information like “Modification is not allowed when using iteration.”
> need further clarification for the discussed use case?
> https://github.com/coccinelle/coccinelle/blob/730dbb034559b3e549ec0b2973cd0400a3fa072f/docs/manual/cocci_syntax.tex#L1999

If you use the argument --in-place, there is no restriction.

julia

[-- Attachment #2: Type: text/plain, Size: 136 bytes --]

_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

  parent reply index

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-28 17:21 [Cocci] Checking the influence of an omitted semicolon on a code adjustment Markus Elfring
2020-11-28 17:45 ` Julia Lawall
2020-11-28 18:56   ` Markus Elfring
2020-11-28 19:00     ` Julia Lawall
2020-11-28 19:11       ` Markus Elfring
2020-11-28 19:49         ` Julia Lawall
2020-11-28 20:04           ` Markus Elfring
     [not found]             ` <0148bab2-6148-e403-985d-df2e7cade490@web.de>
2020-11-29 11:54               ` [Cocci] Adjusting some calls according to pass-through functions Julia Lawall
     [not found]                 ` <3b134eb3-7ccf-454c-3266-64cfaec5a307@web.de>
2020-11-29 12:25                   ` Julia Lawall
     [not found]                     ` <978f08c3-21ed-d434-d2ef-163335ae990e@web.de>
2020-11-29 12:52                       ` Julia Lawall [this message]
     [not found]                         ` <1dc8f835-11b1-0ec0-8ba4-45cffdf13465@web.de>
2020-11-29 13:47                           ` Julia Lawall
     [not found]                     ` <cb266001-ed38-da76-389c-5a7bf7f59e9e@web.de>
2020-11-29 13:43                       ` Julia Lawall
     [not found]                         ` <79d4245d-6f34-7b8d-d632-99afcc1d228a@web.de>
2020-11-29 14:44                           ` Julia Lawall
     [not found]                             ` <beeb673b-65b5-fdef-f300-c86a4bd0abc7@web.de>
2020-11-29 15:18                               ` Julia Lawall
     [not found]                                 ` <cf0e2d68-d76b-5892-b97e-36a270732028@web.de>
2020-11-29 15:52                                   ` Julia Lawall
     [not found]                                     ` <b548f18b-2fa7-1fcf-5bbb-3011d8a270e5@web.de>
2020-11-29 16:24                                       ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.22.394.2011291351210.2671@hadrien \
    --to=julia.lawall@inria.fr \
    --cc=Markus.Elfring@web.de \
    --cc=cocci@systeme.lip6.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Coccinelle Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/cocci/0 cocci/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 cocci cocci/ https://lore.kernel.org/cocci \
		cocci@systeme.lip6.fr
	public-inbox-index cocci

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/fr.lip6.systeme.cocci


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git