From: Julia Lawall <julia.lawall@inria.fr>
To: Ira Weiny <ira.weiny@intel.com>
Cc: cocci@systeme.lip6.fr
Subject: Re: [Cocci] Itterating matches
Date: Tue, 1 Dec 2020 11:06:13 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2012011105330.2666@hadrien> (raw)
In-Reply-To: <20201130210624.GR1161629@iweiny-DESK2.sc.intel.com>
> But the kaddr in check_compressed_csum() is used?
>
> 148 char *kaddr;
> 149 u8 csum[BTRFS_CSUM_SIZE];
> 150 struct compressed_bio *cb = bio->bi_private;
> 151 u8 *cb_sum = cb->sums;
> 152
> 153 if (inode->flags & BTRFS_INODE_NODATASUM)
> 154 return 0;
> 155
> 156 shash->tfm = fs_info->csum_shash;
> 157
> 158 for (i = 0; i < cb->nr_pages; i++) {
> 159 page = cb->compressed_pages[i];
> 160
> 161 kaddr = kmap_atomic(page);
> 162 crypto_shash_digest(shash, kaddr, PAGE_SIZE, csum);
> 163 kunmap_atomic(kaddr);
>
> It correctly leaves this kmap_atomic alone for me.
OK, that's strange. I will take a look.
julia
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
next prev parent reply other threads:[~2020-12-01 10:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-28 5:41 [Cocci] Itterating matches Ira Weiny
2020-11-28 7:55 ` Julia Lawall
2020-11-30 19:19 ` Ira Weiny
2020-11-30 19:59 ` Julia Lawall
2020-11-30 21:06 ` Ira Weiny
2020-12-01 10:06 ` Julia Lawall [this message]
[not found] ` <13b5bbf1-4dda-9dc2-46cd-a98e71537769@web.de>
2020-11-30 22:48 ` [Cocci] Automating a kmap/mem*/kunmap transformation Ira Weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2012011105330.2666@hadrien \
--to=julia.lawall@inria.fr \
--cc=cocci@systeme.lip6.fr \
--cc=ira.weiny@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).