From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5F01C433DB for ; Mon, 11 Jan 2021 20:24:13 +0000 (UTC) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E4A2D22C7B for ; Mon, 11 Jan 2021 20:24:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E4A2D22C7B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=inria.fr Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=cocci-bounces@systeme.lip6.fr Received: from systeme.lip6.fr (systeme.lip6.fr [132.227.104.7]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTP id 10BKNi3s001973; Mon, 11 Jan 2021 21:23:44 +0100 (CET) Received: from systeme.lip6.fr (systeme.lip6.fr [127.0.0.1]) by systeme.lip6.fr (Postfix) with ESMTP id BF8AB77B8; Mon, 11 Jan 2021 21:23:44 +0100 (CET) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by systeme.lip6.fr (Postfix) with ESMTPS id 10ECB74B6 for ; Mon, 11 Jan 2021 21:23:43 +0100 (CET) Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTP id 10BKNdq3021834 for ; Mon, 11 Jan 2021 21:23:39 +0100 (CET) X-IronPort-AV: E=Sophos;i="5.79,339,1602540000"; d="scan'208";a="486525003" Received: from 173.121.68.85.rev.sfr.net (HELO hadrien) ([85.68.121.173]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jan 2021 21:23:39 +0100 Date: Mon, 11 Jan 2021 21:23:39 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Denis Efremov In-Reply-To: <854fdad7-cf2d-49d8-571c-1ac64fa90fb6@linux.com> Message-ID: References: <854fdad7-cf2d-49d8-571c-1ac64fa90fb6@linux.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 X-Greylist: Sender IP whitelisted, Sender e-mail whitelisted, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Mon, 11 Jan 2021 21:23:45 +0100 (CET) X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Mon, 11 Jan 2021 21:23:39 +0100 (CET) X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 Cc: Coccinelle Subject: Re: [Cocci] How to match function-like macro calls, e.g. RTA_ALIGN(rta->rta_len)? X-BeenThere: cocci@systeme.lip6.fr X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: cocci-bounces@systeme.lip6.fr Errors-To: cocci-bounces@systeme.lip6.fr On Mon, 11 Jan 2021, Denis Efremov wrote: > Hi, > > Let's suppose I want to match otx_cpt_aead_cbc_aes_sha_setkey() function from > drivers/crypto/marvell/octeontx/otx_cptvf_algs.c file (linux kernel). > > My pattern: > @exists@ > identifier rta, param, key, keylen; > position p; > @@ > > otx_cpt_aead_cbc_aes_sha_setkey(..., > unsigned char *key, unsigned int keylen) > { > ... > * if (RTA_PAYLOAD(rta) < sizeof(*param))@p > goto badkey; > ... > * key += RTA_ALIGN(rta->rta_len); > * keylen -= RTA_ALIGN(rta->rta_len); > ... > } > > $ spatch --no-includes --include-headers --cocci-file test.cocci drivers/crypto/marvell/octeontx/otx_cptvf_algs.c > init_defs_builtins: /usr/lib64/coccinelle/standard.h > minus: parse error: > File "test.cocci", line 13, column 9, charpos = 219 > around = 'RTA_ALIGN', > whole content = * key += RTA_ALIGN(rta->rta_len); > > > What can I do to match RTA_ALIGN(...) lines? I don't understand the problem. I took your rule and your command line, and everything was fine. julia _______________________________________________ Cocci mailing list Cocci@systeme.lip6.fr https://systeme.lip6.fr/mailman/listinfo/cocci