[cocci] Coccinelle does not parse macros ending in a comma

[cocci] Coccinelle does not parse macros ending in a comma

[Lucian Popescu]

[-- Attachment #1: Type: text/plain, Size: 951 bytes --]

Hi,

I ran spatch --parse-c on the following code:

#define something 0,

int main() {
    return 0;
}

This code compiles fine according to the C standard, however the output of
spatch is:

init_defs_builtins: /usr/local/lib/coccinelle/standard.h

PARSING: test.c
ERROR-RECOV: found sync end of #define, line 1
parsing pass2: try again
ERROR-RECOV: found sync end of #define, line 1
parse error
 = File "test.c", line 1, column 20, charpos = 20
  around = '',
  whole content = #define something 0,
badcount: 0
BAD:!!!!! #define something 0,
-----------------------------------------------------------------------
maybe 10 most problematic tokens
-----------------------------------------------------------------------
something: present in 1 parsing errors
example:

       #define something 0,

-----------------------------------------------------------------------

Is this a known limitation? If not, is there a way to solve this issue?

Lucian

[-- Attachment #2: Type: text/html, Size: 1244 bytes --]

Re: [cocci] Coccinelle does not parse macros ending in a comma

[Julia Lawall]

[-- Attachment #1: Type: text/plain, Size: 1315 bytes --]



On Sat, 25 Jun 2022, Lucian Popescu wrote:

> Hi,
> I ran spatch --parse-c on the following code:
>
> #define something 0,
>
> int main() {
>     return 0;
> }
>
> This code compiles fine according to the C standard, however the output of
> spatch is:
>
> init_defs_builtins: /usr/local/lib/coccinelle/standard.h
>
> PARSING: test.c
> ERROR-RECOV: found sync end of #define, line 1
> parsing pass2: try again
> ERROR-RECOV: found sync end of #define, line 1
> parse error
>  = File "test.c", line 1, column 20, charpos = 20
>   around = '',
>   whole content = #define something 0,
> badcount: 0
> BAD:!!!!! #define something 0,
> -----------------------------------------------------------------------
> maybe 10 most problematic tokens
> -----------------------------------------------------------------------
> something: present in 1 parsing errors
> example:
>        
>        #define something 0,
>        
> -----------------------------------------------------------------------
>
> Is this a known limitation? If not, is there a way to solve this issue?

This is the expected behavior.  Is there something that ou want to do
withe macro definition?  The inability to parse that shouldn't impact the
ability to treat other code, at least not other code that doesn't use the
macro.

julia