From: Markus Elfring <Markus.Elfring@web.de>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Coccinelle <cocci@systeme.lip6.fr>
Subject: Re: [Cocci] Software analysis with SmPL around unchecked function calls
Date: Fri, 11 Oct 2019 07:11:05 +0200
Message-ID: <b76c96ca-4312-550a-3f56-a509c63faa0f@web.de> (raw)
In-Reply-To: <alpine.DEB.2.21.1910102053440.2500@hadrien>
> And what is the questionable source code place?
I find implementation details occasionally questionable where checks for variables
which provide a stored function return value are missing.
The possibility remains that also your search pattern suggestion will point
update candidates out at other places than the implementation of the mentioned
function “imx_pd_bind”.
How do you think about the following SmPL script variant?
@display@
expression x, y;
identifier f, md;
@@
*(x)->md = kmemdup(...);
... when != (x)->md
(((x)->md)->f
|f(..., <+... x ...+>, ...)
|(y = x)
)
Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
next prev parent reply index
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 12:56 Markus Elfring
2019-10-10 13:13 ` Julia Lawall
2019-10-10 13:35 ` Markus Elfring
2019-10-10 13:38 ` Julia Lawall
2019-10-10 14:04 ` Markus Elfring
[not found] ` <alpine.DEB.2.21.1910101606420.2305@hadrien>
2019-10-10 14:15 ` Markus Elfring
[not found] ` <alpine.DEB.2.21.1910102053440.2500@hadrien>
2019-10-11 5:11 ` Markus Elfring [this message]
2019-10-11 6:07 ` Julia Lawall
2019-10-11 7:03 ` Markus Elfring
[not found] ` <alpine.DEB.2.21.1910110906390.2662@hadrien>
2019-10-11 7:30 ` Markus Elfring
2019-10-11 9:23 ` Markus Elfring
2019-10-10 16:25 ` Markus Elfring
2019-10-18 12:54 ` [Cocci] Software analysis with SmPL around unchecked pointer " Markus Elfring
2019-10-18 13:31 ` Julia Lawall
2019-10-18 13:42 ` Markus Elfring
2019-10-18 13:49 ` Julia Lawall
2019-10-18 14:20 ` Markus Elfring
2019-10-18 14:30 ` Julia Lawall
2019-10-18 14:34 ` Markus Elfring
2019-10-18 14:39 ` Julia Lawall
2019-10-18 14:46 ` Markus Elfring
2019-10-18 14:52 ` Julia Lawall
2019-10-18 14:56 ` Markus Elfring
2019-10-18 16:00 ` Markus Elfring
2019-10-18 16:06 ` Julia Lawall
2019-10-18 16:32 ` Markus Elfring
2019-10-19 15:33 ` Markus Elfring
2019-10-19 15:41 ` Julia Lawall
2019-10-19 16:04 ` Markus Elfring
2019-10-19 19:40 ` Markus Elfring
2019-10-20 5:42 ` Julia Lawall
2019-10-20 6:04 ` Markus Elfring
2019-10-20 9:22 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b76c96ca-4312-550a-3f56-a509c63faa0f@web.de \
--to=markus.elfring@web.de \
--cc=cocci@systeme.lip6.fr \
--cc=julia.lawall@lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Coccinelle Archive on lore.kernel.org
Archives are clonable:
git clone --mirror https://lore.kernel.org/cocci/0 cocci/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 cocci cocci/ https://lore.kernel.org/cocci \
cocci@systeme.lip6.fr
public-inbox-index cocci
Example config snippet for mirrors
Newsgroup available over NNTP:
nntp://nntp.lore.kernel.org/fr.lip6.systeme.cocci
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git