From: Markus Elfring <Markus.Elfring@web.de>
To: Coccinelle <cocci@systeme.lip6.fr>
Subject: Re: [Cocci] xusb-tegra186: Renaming known jump labels with SmPL?
Date: Wed, 30 Oct 2019 18:30:26 +0100 [thread overview]
Message-ID: <c618d696-4934-9648-bd4f-7220116d3120@web.de> (raw)
In-Reply-To: <161bbb97-09d9-f128-bd25-ef9348534144@web.de>
> But I stumble on another unexpected test result.
I have tried a related tiny transformation approach out.
@renaming@
@@
-out
+exit
:
return ERR_PTR(...);
I got a diff hunk like the following then.
elfring@Sonne:~/Projekte/Linux/next-patched> spatch drivers/phy/tegra/xusb-tegra186.c ~/Projekte/Coccinelle/janitor/rename_out_label1.cocci
…
warning: line 3: should out be a metavariable?
…
@@ -483,7 +483,7 @@ tegra186_usb2_pad_probe(struct tegra_xus
unregister:
device_unregister(&pad->dev);
-out:
+exit :
return ERR_PTR(err);
}
…
Should the addition of an extra space character usually be avoided
for such a jump label?
Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
next prev parent reply other threads:[~2019-10-30 17:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <fe6868a4-01f5-2832-9081-7643be0ab4a1@web.de>
2019-10-29 9:40 ` [Cocci] phy: tegra: xusb: Complete exception handling in probe functions Markus Elfring
2019-10-30 10:44 ` [Cocci] drivers/phy/tegra: Completion for exception handling in probe functions with SmPL? Markus Elfring
2019-10-30 17:30 ` Markus Elfring [this message]
2019-10-30 18:15 ` [Cocci] xusb-tegra186: Adding a function call behind a label " Markus Elfring
[not found] ` <2db8691d768571f6c275f3d89401df23@lip6.fr>
2019-10-30 20:00 ` Markus Elfring
2019-10-30 20:44 ` Julia Lawall
2019-10-31 8:12 ` Markus Elfring
2019-10-30 20:50 ` [Cocci] drivers/phy/tegra: Completion for exception handling in probe functions " Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c618d696-4934-9648-bd4f-7220116d3120@web.de \
--to=markus.elfring@web.de \
--cc=cocci@systeme.lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).