From: Joe Perches <joe@perches.com>
To: David Laight <David.Laight@ACULAB.COM>,
Julia Lawall <julia.lawall@inria.fr>
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>,
Kees Cook <keescook@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
cocci <cocci@systeme.lip6.fr>,
"accessrunner-general@lists.sourceforge.net"
<accessrunner-general@lists.sourceforge.net>,
Alex Dewar <alex.dewar90@gmail.com>
Subject: Re: [Cocci] [PATCH] usb: atm: don't use snprintf() for sysfs attrs
Date: Thu, 27 Aug 2020 15:11:57 -0700 [thread overview]
Message-ID: <ca08f34a5aaa3e9031a934296dd97fc806dab66f.camel@perches.com> (raw)
In-Reply-To: <c3926f18f98e446daad957cd66a94890@AcuMS.aculab.com>
On Thu, 2020-08-27 at 22:03 +0000, David Laight wrote:
> From: Joe Perches
> > Sent: 27 August 2020 21:30
> ...
> > Perhaps what's necessary is to find any
> > appropriate .show function and change
> > any use of strcpy/sprintf within those
> > function to some other name.
> >
> > For instance:
> >
> > drivers/isdn/mISDN/core.c-static ssize_t name_show(struct device *dev,
> > drivers/isdn/mISDN/core.c- struct device_attribute *attr, char *buf)
> > drivers/isdn/mISDN/core.c-{
> > drivers/isdn/mISDN/core.c: strcpy(buf, dev_name(dev));
> > drivers/isdn/mISDN/core.c- return strlen(buf);
> > drivers/isdn/mISDN/core.c-}
> > drivers/isdn/mISDN/core.c-static DEVICE_ATTR_RO(name);
>
> That form ends up calculating the string length twice.
> Better would be:
> len = strlen(msg);
> memcpy(buf, msg, len);
> return len;
or given clang's requirement for stpcpy
return stpcpy(buf, dev_name(dev)) - buf;
(I do not advocate for this ;)
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
next prev parent reply other threads:[~2020-08-27 22:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200824222322.22962-1-alex.dewar90@gmail.com>
[not found] ` <48f2dc90-7852-eaf1-55d7-2c85cf954688@rasmusvillemoes.dk>
[not found] ` <20200827071537.GA168593@kroah.com>
[not found] ` <20200827131819.7rcl2f5js3hkoqj2@lenovo-laptop>
[not found] ` <def24e9e-018c-9712-0d07-d4cbc84f07d9@rasmusvillemoes.dk>
[not found] ` <20200827144846.yauuttjaqtxaldxg@lenovo-laptop>
2020-08-27 16:58 ` [Cocci] [PATCH] usb: atm: don't use snprintf() for sysfs attrs Joe Perches
2020-08-27 19:42 ` Julia Lawall
2020-08-27 20:29 ` Joe Perches
2020-08-27 21:00 ` Joe Perches
2020-08-27 21:29 ` Julia Lawall
2020-08-27 22:03 ` David Laight
2020-08-27 22:11 ` Joe Perches [this message]
2020-08-27 22:16 ` Kees Cook
2020-08-27 21:01 ` Denis Efremov
2020-08-27 21:36 ` Julia Lawall
2020-08-27 21:44 ` Joe Perches
2020-08-27 22:38 ` Denis Efremov
2020-08-27 22:48 ` Joe Perches
2020-08-27 22:20 ` Kees Cook
2020-08-27 22:45 ` Joe Perches
2020-08-28 4:12 ` Joe Perches
2020-08-28 7:58 ` Kees Cook
2020-08-28 8:10 ` Joe Perches
2020-08-28 8:22 ` Joe Perches
2020-08-28 7:39 ` David Laight
2020-08-27 21:54 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca08f34a5aaa3e9031a934296dd97fc806dab66f.camel@perches.com \
--to=joe@perches.com \
--cc=David.Laight@ACULAB.COM \
--cc=accessrunner-general@lists.sourceforge.net \
--cc=alex.dewar90@gmail.com \
--cc=cocci@systeme.lip6.fr \
--cc=gregkh@linuxfoundation.org \
--cc=gustavoars@kernel.org \
--cc=julia.lawall@inria.fr \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).