From: Tom Rix <trix@redhat.com>
To: Joe Perches <joe@perches.com>,
linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com,
cocci <cocci@systeme.lip6.fr>
Cc: alsa-devel@alsa-project.org, linux-aspeed@lists.ozlabs.org,
linux-iio@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-scsi@vger.kernel.org, linux-rdma@vger.kernel.org,
qat-linux@intel.com, amd-gfx@lists.freedesktop.org,
linux-pm@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org,
linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-nfs@vger.kernel.org, netdev@vger.kernel.org,
linux-mmc@vger.kernel.org, tipc-discussion@lists.sourceforge.net,
linux-crypto@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [Cocci] Subject: [RFC] clang tooling cleanups
Date: Tue, 10 Nov 2020 05:12:26 -0800 [thread overview]
Message-ID: <cc512954-2e1d-a165-f1f1-2c489fd6d3a9@redhat.com> (raw)
In-Reply-To: <3c39c363690d0b46069afddc3ad09213011e5cd4.camel@perches.com>
On 11/9/20 6:52 PM, Joe Perches wrote:
> On Tue, 2020-10-27 at 09:42 -0700, trix@redhat.com wrote:
>> This rfc will describe
>> An upcoming treewide cleanup.
>> How clang tooling was used to programatically do the clean up.
>> Solicit opinions on how to generally use clang tooling.
>>
>> The clang warning -Wextra-semi-stmt produces about 10k warnings.
>> Reviewing these, a subset of semicolon after a switch looks safe to
>> fix all the time. An example problem
>>
>> void foo(int a) {
>> switch(a) {
>> case 1:
>> ...
>> }; <--- extra semicolon
>> }
>>
>> Treewide, there are about 100 problems in 50 files for x86_64 allyesconfig.
>> These fixes will be the upcoming cleanup.
> coccinelle already does some of these.
>
> For instance: scripts/coccinelle/misc/semicolon.cocci
>
> Perhaps some tool coordination can be done here as
> coccinelle/checkpatch/clang/Lindent call all be used
> to do some facet or another of these cleanup issues.
Thanks for pointing this out.
I will take a look at it.
Tom
>
>
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
prev parent reply other threads:[~2020-11-10 14:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201027164255.1573301-1-trix@redhat.com>
2020-11-10 2:52 ` [Cocci] Subject: [RFC] clang tooling cleanups Joe Perches
2020-11-10 13:12 ` Tom Rix [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc512954-2e1d-a165-f1f1-2c489fd6d3a9@redhat.com \
--to=trix@redhat.com \
--cc=alsa-devel@alsa-project.org \
--cc=amd-gfx@lists.freedesktop.org \
--cc=clang-built-linux@googlegroups.com \
--cc=cocci@systeme.lip6.fr \
--cc=dri-devel@lists.freedesktop.org \
--cc=joe@perches.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-tegra@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=qat-linux@intel.com \
--cc=tipc-discussion@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).