cocci.inria.fr archive mirror
 help / color / mirror / Atom feed
From: Denis Efremov <efremov@linux.com>
To: Julia Lawall <julia.lawall@inria.fr>,
	Markus Elfring <Markus.Elfring@web.de>
Cc: Coccinelle <cocci@systeme.lip6.fr>, linux-kernel@vger.kernel.org
Subject: Re: [Cocci] [v2 1/4] coccinelle: api: extend memdup_user transformation with GFP_USER
Date: Sat, 18 Jul 2020 16:11:20 +0300	[thread overview]
Message-ID: <cf2bd604-3094-f90a-52a8-ff5a44cf3850@linux.com> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2007180841520.2538@hadrien>

Hi,

On 7/18/20 9:45 AM, Julia Lawall wrote:
> This on is indeed a problem.  I think it was not detected in testing,
> because in the current kernel the rule never applies.  But Denis, in
> 
> -  to = \(kmalloc\|kzalloc\)
>                 (size,\(GFP_KERNEL\|GFP_USER\|
>                       \(GFP_KERNEL\|GFP_USER\)|__GFP_NOWARN\));
> 
> you do indeed need to put - in front of the second and third lines as
> well.

Thanks, Markus, Julia. I will send v3. Julia, is it ok with you, if I will
drop the last patch with "selfcheck" this time?

Regards,
Denis
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

  parent reply	other threads:[~2020-07-18 13:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <0b9f2c58-e124-22d2-d91d-62a6e831c880@web.de>
2020-07-18  6:45 ` [Cocci] [v2 1/4] coccinelle: api: extend memdup_user transformation with GFP_USER Julia Lawall
     [not found]   ` <fa0ec546-9aee-5c95-428c-a225a3521f6f@web.de>
2020-07-18  8:41     ` Julia Lawall
2020-07-18 13:11   ` Denis Efremov [this message]
2020-07-18 13:29     ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cf2bd604-3094-f90a-52a8-ff5a44cf3850@linux.com \
    --to=efremov@linux.com \
    --cc=Markus.Elfring@web.de \
    --cc=cocci@systeme.lip6.fr \
    --cc=julia.lawall@inria.fr \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).