Coccinelle archive on lore.kernel.org
 help / color / Atom feed
From: Jaskaran Singh <jaskaransingh7654321@gmail.com>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
	Markus Elfring <Markus.Elfring@web.de>,
	"cocci@systeme.lip6.fr" <cocci@systeme.lip6.fr>
Subject: Re: [Cocci] [PATCH] parsing_c: Add space for tokens after *
Date: Thu, 16 Jan 2020 17:01:59 +0530
Message-ID: <d2507ff6b1b9e89503f4171da6fbc80b3382d4ce.camel@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2001161158440.3888@hadrien>

On Thu, 2020-01-16 at 11:59 +0100, Julia Lawall wrote:
> 
> On Thu, 16 Jan 2020, Jaskaran Singh wrote:
> 
> > On Thu, 2020-01-16 at 11:40 +0100, Markus Elfring wrote:
> > > > In certain cases, there is no space added after the Pointer
> > > > type.
> > > 
> > > Will such a pretty-printing detail matter also for the
> > > clarification
> > > of
> > > a topic like “Make change influence configurable for coding style
> > > rules”?
> > > https://github.com/coccinelle/coccinelle/issues/37
> > > 
> > 
> > Not sure what you mean. If you mean to say that the result should
> > conform to the Linux coding style (i.e. the result should be "const
> > char * const * y" with spaces et al intact), that seems like
> > something
> > for a different patch, right? Whether you want Coccinelle to
> > conform to
> > Linux coding style or not, the space should be added either way.
> 
> The option --smpl-spacing should address this issue, by preservign
> the
> spacing illustrated in the semantic patch.  I don't know if it does
> that
> in this case.
> 

Hm, can't say that it does. Here's what I get with --smpl-spacing on
case https://www.mail-archive.com/cocci@systeme.lip6.fr/msg06696.html

before:

 void main() {
-	const char * const * x;
+	const char *const*y  ;
 }

after:

 void main() {
-	const char * const * x;
+	const char *const *y  ;
 }

Cheers,
Jaskaran.

> julia
> 
> > Cheers,
> > Jaskaran.
> > 
> > > Regards,
> > > Markus
> > 
> > _______________________________________________
> > Cocci mailing list
> > Cocci@systeme.lip6.fr
> > https://systeme.lip6.fr/mailman/listinfo/cocci

_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

  reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-16 10:40 Markus Elfring
2020-01-16 10:56 ` Jaskaran Singh
2020-01-16 10:59   ` Julia Lawall
2020-01-16 11:31     ` Jaskaran Singh [this message]
2020-01-16 11:36       ` Jaskaran Singh
2020-01-16 13:02   ` [Cocci] " Markus Elfring
  -- strict thread matches above, loose matches on Subject: below --
2020-01-16  5:18 [Cocci] [PATCH] " Jaskaran Singh
2020-01-16  9:09 ` Julia Lawall

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d2507ff6b1b9e89503f4171da6fbc80b3382d4ce.camel@gmail.com \
    --to=jaskaransingh7654321@gmail.com \
    --cc=Markus.Elfring@web.de \
    --cc=cocci@systeme.lip6.fr \
    --cc=julia.lawall@inria.fr \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Coccinelle archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/cocci/0 cocci/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 cocci cocci/ https://lore.kernel.org/cocci \
		cocci@systeme.lip6.fr
	public-inbox-index cocci

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/fr.lip6.systeme.cocci


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git