From: Markus Elfring <Markus.Elfring@web.de>
To: Julia Lawall <julia.lawall@lip6.fr>,
Joe Perches <joe@perches.com>,
cocci@systeme.lip6.fr, kernel-janitors@vger.kernel.org
Cc: David Laight <David.Laight@ACULAB.COM>, linux-kernel@vger.kernel.org
Subject: Re: [Cocci] [PATCH 1/2] string: Add stracpy and stracpy_pad mechanisms
Date: Thu, 25 Jul 2019 09:46:00 +0200 [thread overview]
Message-ID: <e3a37d93-0353-ebed-948a-991add184616@web.de> (raw)
In-Reply-To: <alpine.DEB.2.21.1907242040490.10108@hadrien>
> New version. I check for non-use of the return value of strlcpy and
> address some issues that affected the matching of the case where the first
> argument involves a pointer dereference.
I suggest to take another look at corresponding implementation details
of the shown SmPL script.
> \(strscpy\|strlcpy\)(e1.f, e2, i2)@p
Can the data access operator “->” (arrow) matter also here?
> @@
> identifier r.i1,r.i2;
> type T;
> @@
> struct i1 { ... T i1[i2]; ... }
Will an additional SmPL rule name be helpful for this part?
> @@
> (
> -x = strlcpy
> +stracpy
> (e1.f, e2
> - , i2
> )@p;
> ... when != x
>
> |
I wonder about the deletion of the assignment target.
Should the setting of such a variable be usually preserved?
Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
next prev parent reply other threads:[~2019-07-25 7:46 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <7ab8957eaf9b0931a59eff6e2bd8c5169f2f6c41.1563841972.git.joe@perches.com>
2019-07-23 0:46 ` [Cocci] [Fwd: [PATCH 1/2] string: Add stracpy and stracpy_pad mechanisms] Joe Perches
2019-07-23 20:52 ` Julia Lawall
2019-07-23 23:42 ` Joe Perches
2019-07-24 3:54 ` Julia Lawall
2019-07-24 4:19 ` Joe Perches
2019-07-24 4:27 ` Julia Lawall
2019-07-24 4:37 ` Joe Perches
2019-07-24 10:28 ` David Laight
2019-07-24 10:43 ` Joe Perches
2019-07-24 11:45 ` Julia Lawall
2019-07-25 1:42 ` Julia Lawall
2019-07-25 7:46 ` Markus Elfring [this message]
2019-07-25 11:34 ` [Cocci] [PATCH 1/2] string: Add stracpy and stracpy_pad mechanisms Julia Lawall
2019-07-25 12:40 ` [Cocci] [1/2] " Markus Elfring
2019-07-25 13:45 ` [Cocci] [PATCH 1/2] " Markus Elfring
2019-07-25 13:48 ` Julia Lawall
2019-07-25 14:48 ` [Cocci] [1/2] " Markus Elfring
2019-07-25 13:50 ` [Cocci] [Fwd: [PATCH 1/2] string: Add stracpy and stracpy_pad mechanisms] Joe Perches
2019-07-25 13:58 ` Julia Lawall
2019-07-25 14:12 ` Joe Perches
2019-07-25 22:51 ` Julia Lawall
2019-07-26 6:15 ` [Cocci] [1/2] string: Add stracpy and stracpy_pad mechanisms Markus Elfring
2019-07-29 14:07 ` [Cocci] [Fwd: [PATCH 1/2] string: Add stracpy and stracpy_pad mechanisms] Julia Lawall
2019-07-29 16:28 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3a37d93-0353-ebed-948a-991add184616@web.de \
--to=markus.elfring@web.de \
--cc=David.Laight@ACULAB.COM \
--cc=cocci@systeme.lip6.fr \
--cc=joe@perches.com \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).