From: remicles2@gmail.com (Remington Furman)
To: cocci@systeme.lip6.fr
Subject: [Cocci] Parse error with genl-const.cocci
Date: Tue, 12 Dec 2017 07:19:51 -0800 [thread overview]
Message-ID: <e589e785-6e08-8b37-8017-09ffc8627de2@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1712011059360.2865@hadrien>
On 12/01/2017 02:00 AM, Julia Lawall wrote:
> On Fri, 1 Dec 2017, Johannes Berg wrote:
>> Hi Julia,
>>
>> On Fri, 2017-12-01 at 10:18 +0100, Julia Lawall wrote:
>>> The handling of attributes has also been extended so that you can actually
>>> match against them in some cases, such as on function declarations. On
>>> the oher hand, nothing was done to allow attributes in front of types that
>>> are alone.
>> Very cool!
>>> I can try to fix this. In the short term, perhaps using 1.0.4 is
>>> acceptable.
>> To me that's OK, I'll try to keep it in mind.
>>
>> Can we do some "#ifdef" type syntax in spatch on the version of it? :-)
> There's nothing for that available at the moment.
>> I guess I could also have two different versions of the patch and write
>> some code to pick up which one to use, but that's a bit awkward ...
>>
>> But let me know if you can't actually fix this (easily), then I can do
>> that instead.
> OK, I'll try to look at it soon.
>
> julia
I thought I'd point out the layers of coevolution that result from the
changing spatch behavior.? :) It's a bit fractal when every layer in the
dependency graph has the possibility to change.? I suppose a #ifdef type
solution might remove the potential need to backport the .cocci patches
themselves going forward.
But, I think it might be sufficient to just document what version of the
tools, in this case spatch, were used for a particular backports
commit/release.? It's easy enough to build any version of spatch from
git.? Or perhaps each .cocci patch could have a comment listing the
spatch version it was developed with.? Future backports releases could
then update the patch syntax as needed, document the spatch version, and
leave it at that.
-Remington
next prev parent reply other threads:[~2017-12-12 15:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <925f98d2-047f-785f-4162-21b53a77cd62@gmail.com>
2017-12-01 8:27 ` [Cocci] Parse error with genl-const.cocci Johannes Berg
2017-12-01 9:18 ` Julia Lawall
2017-12-01 9:29 ` Johannes Berg
2017-12-01 10:00 ` Julia Lawall
2017-12-12 15:19 ` Remington Furman [this message]
2017-12-14 15:16 ` Julia Lawall
2017-12-19 9:41 ` Johannes Berg
2018-06-25 20:33 ` Johannes Berg
2017-12-01 17:57 ` Remington Furman
2017-12-01 18:02 ` Johannes Berg
2017-12-01 18:09 ` Remington Furman
2017-12-01 23:48 ` Remington Furman
2017-12-02 7:47 ` Johannes Berg
2017-12-01 18:57 ` Julia Lawall
2017-12-01 19:39 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e589e785-6e08-8b37-8017-09ffc8627de2@gmail.com \
--to=remicles2@gmail.com \
--cc=cocci@systeme.lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).