From: Jaskaran Singh <jaskaransingh7654321@gmail.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: "linux-kernel-mentees@lists.linuxfoundation.org"
<linux-kernel-mentees@lists.linuxfoundation.org>,
"cocci@systeme.lip6.fr" <cocci@systeme.lip6.fr>
Subject: Re: [Cocci] [PATCH 1/2] parsing_c: Align C AST and Cocci AST for pointers
Date: Thu, 06 Feb 2020 17:20:00 +0530 [thread overview]
Message-ID: <e602666d72bb5a46a1f9f98cb1ee440b4c3dd16a.camel@gmail.com> (raw)
In-Reply-To: <6e8147b7-da54-376f-0684-aee159e23d8e@web.de>
On Wed, 2020-02-05 at 19:36 +0100, Markus Elfring wrote:
> …
> > +++ b/parsing_c/pretty_print_c.ml
> > @@ -804,11 +804,12 @@ and pp_string_format (e,ii) =
> > (FunctionType (return=void, params=int i) *)
> > (*WRONG I THINK, use left & right function *)
> > (* bug: pp_type_with_ident_rest None t; print_ident
> > ident *)
> > + pp_type_left t;
> > pr_elem i;
> > iiqu +> List.iter pr_elem; (* le const est forcement
> > apres le '*' *)
> > if iiqu <> [] || get_comments_after i <> []
> > then pr_space();
> > - pp_type_with_ident_rest ident t attrs Ast_c.noattr;
> > + print_ident ident
> >
> > (* ugly special case ... todo? maybe sufficient in practice
> > *)
> > | (ParenType ttop, [i1;i2]) ->
>
> Are the source code comments still appropriate for this patch hunk?
>
I know the "le const est forcement" comment is still appropriate.
The bug comment above probably still is.
Not so sure about the WRONG I THINK comment. I'm using pp_type_left
here, but not pp_type_right. Of course, that is if the comment is in
that context.
Cheers,
Jaskaran.
> Regards,
> Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
prev parent reply other threads:[~2020-02-06 11:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 18:36 [Cocci] [PATCH 1/2] parsing_c: Align C AST and Cocci AST for pointers Markus Elfring
2020-02-06 11:50 ` Jaskaran Singh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e602666d72bb5a46a1f9f98cb1ee440b4c3dd16a.camel@gmail.com \
--to=jaskaransingh7654321@gmail.com \
--cc=Markus.Elfring@web.de \
--cc=cocci@systeme.lip6.fr \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).