From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F89FC31E51 for ; Tue, 18 Jun 2019 05:38:22 +0000 (UTC) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4495820863 for ; Tue, 18 Jun 2019 05:38:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=web.de header.i=@web.de header.b="IetzS48o" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4495820863 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=web.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=cocci-bounces@systeme.lip6.fr Received: from systeme.lip6.fr (systeme.lip6.fr [132.227.104.7]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTP id x5I5c3U6025695; Tue, 18 Jun 2019 07:38:03 +0200 (CEST) Received: from systeme.lip6.fr (systeme.lip6.fr [127.0.0.1]) by systeme.lip6.fr (Postfix) with ESMTP id 2FF9A7779; Tue, 18 Jun 2019 07:38:03 +0200 (CEST) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by systeme.lip6.fr (Postfix) with ESMTPS id A4E697767 for ; Tue, 18 Jun 2019 07:38:01 +0200 (CEST) Received: from mout.web.de (mout.web.de [212.227.15.3]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTP id x5I5c0KK004984; Tue, 18 Jun 2019 07:38:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1560836266; bh=wPYT/Tk8mwDJr/8Vv+qTPSgrjnaPxdetiDnuQai+Ivo=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=IetzS48oZ9t3lkLDffCcSNqMjHHo+8rITaiRX1nTUvc7RJtBrc7b8djJBZowiYXqu 3e5wXjKCNvDSU/qRZklz9yqwDLhGqrLrZ644BWNmmKB6mGlVS//cufdDf6lE1NGsk3 +s3RuNzgarzrDs23LEHvkz2R6EXEmM3RA9z4W1DQ= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.2] ([93.133.86.175]) by smtp.web.de (mrweb003 [213.165.67.108]) with ESMTPSA (Nemesis) id 0M8zRF-1hl2tL0Gar-00CTJv; Tue, 18 Jun 2019 07:37:46 +0200 To: Enrico Weigelt , Greg Kroah-Hartman , "Rafael J. Wysocki" , Bartosz Golaszewski References: <20190406061112.31620-1-himanshujha199640@gmail.com> <7b4fe770-dadd-80ba-2ba4-0f2bc90984ef@web.de> <032e347f-e575-c89c-fa62-473d52232735@web.de> <910a5806-9a08-adf4-4fba-d5ec2f5807ff@metux.net> From: Markus Elfring Openpgp: preference=signencrypt Autocrypt: addr=Markus.Elfring@web.de; prefer-encrypt=mutual; keydata= mQINBFg2+xABEADBJW2hoUoFXVFWTeKbqqif8VjszdMkriilx90WB5c0ddWQX14h6w5bT/A8 +v43YoGpDNyhgA0w9CEhuwfZrE91GocMtjLO67TAc2i2nxMc/FJRDI0OemO4VJ9RwID6ltwt mpVJgXGKkNJ1ey+QOXouzlErVvE2fRh+KXXN1Q7fSmTJlAW9XJYHS3BDHb0uRpymRSX3O+E2 lA87C7R8qAigPDZi6Z7UmwIA83ZMKXQ5stA0lhPyYgQcM7fh7V4ZYhnR0I5/qkUoxKpqaYLp YHBczVP+Zx/zHOM0KQphOMbU7X3c1pmMruoe6ti9uZzqZSLsF+NKXFEPBS665tQr66HJvZvY GMDlntZFAZ6xQvCC1r3MGoxEC1tuEa24vPCC9RZ9wk2sY5Csbva0WwYv3WKRZZBv8eIhGMxs rcpeGShRFyZ/0BYO53wZAPV1pEhGLLxd8eLN/nEWjJE0ejakPC1H/mt5F+yQBJAzz9JzbToU 5jKLu0SugNI18MspJut8AiA1M44CIWrNHXvWsQ+nnBKHDHHYZu7MoXlOmB32ndsfPthR3GSv jN7YD4Ad724H8fhRijmC1+RpuSce7w2JLj5cYj4MlccmNb8YUxsE8brY2WkXQYS8Ivse39MX BE66MQN0r5DQ6oqgoJ4gHIVBUv/ZwgcmUNS5gQkNCFA0dWXznQARAQABtCZNYXJrdXMgRWxm cmluZyA8TWFya3VzLkVsZnJpbmdAd2ViLmRlPokCVAQTAQgAPhYhBHDP0hzibeXjwQ/ITuU9 Figxg9azBQJYNvsQAhsjBQkJZgGABQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEOU9Figx g9azcyMP/iVihZkZ4VyH3/wlV3nRiXvSreqg+pGPI3c8J6DjP9zvz7QHN35zWM++1yNek7Ar OVXwuKBo18ASlYzZPTFJZwQQdkZSV+atwIzG3US50ZZ4p7VyUuDuQQVVqFlaf6qZOkwHSnk+ CeGxlDz1POSHY17VbJG2CzPuqMfgBtqIU1dODFLpFq4oIAwEOG6fxRa59qbsTLXxyw+PzRaR LIjVOit28raM83Efk07JKow8URb4u1n7k9RGAcnsM5/WMLRbDYjWTx0lJ2WO9zYwPgRykhn2 sOyJVXk9xVESGTwEPbTtfHM+4x0n0gC6GzfTMvwvZ9G6xoM0S4/+lgbaaa9t5tT/PrsvJiob kfqDrPbmSwr2G5mHnSM9M7B+w8odjmQFOwAjfcxoVIHxC4Cl/GAAKsX3KNKTspCHR0Yag78w i8duH/eEd4tB8twcqCi3aCgWoIrhjNS0myusmuA89kAWFFW5z26qNCOefovCx8drdMXQfMYv g5lRk821ZCNBosfRUvcMXoY6lTwHLIDrEfkJQtjxfdTlWQdwr0mM5ye7vd83AManSQwutgpI q+wE8CNY2VN9xAlE7OhcmWXlnAw3MJLW863SXdGlnkA3N+U4BoKQSIToGuXARQ14IMNvfeKX NphLPpUUnUNdfxAHu/S3tPTc/E/oePbHo794dnEm57LuuQINBFg2+xABEADZg/T+4o5qj4cw nd0G5pFy7ACxk28mSrLuva9tyzqPgRZ2bdPiwNXJUvBg1es2u81urekeUvGvnERB/TKekp25 4wU3I2lEhIXj5NVdLc6eU5czZQs4YEZbu1U5iqhhZmKhlLrhLlZv2whLOXRlLwi4jAzXIZAu 76mT813jbczl2dwxFxcT8XRzk9+dwzNTdOg75683uinMgskiiul+dzd6sumdOhRZR7YBT+xC wzfykOgBKnzfFscMwKR0iuHNB+VdEnZw80XGZi4N1ku81DHxmo2HG3icg7CwO1ih2jx8ik0r riIyMhJrTXgR1hF6kQnX7p2mXe6K0s8tQFK0ZZmYpZuGYYsV05OvU8yqrRVL/GYvy4Xgplm3 DuMuC7/A9/BfmxZVEPAS1gW6QQ8vSO4zf60zREKoSNYeiv+tURM2KOEj8tCMZN3k3sNASfoG fMvTvOjT0yzMbJsI1jwLwy5uA2JVdSLoWzBD8awZ2X/eCU9YDZeGuWmxzIHvkuMj8FfX8cK/ 2m437UA877eqmcgiEy/3B7XeHUipOL83gjfq4ETzVmxVswkVvZvR6j2blQVr+MhCZPq83Ota xNB7QptPxJuNRZ49gtT6uQkyGI+2daXqkj/Mot5tKxNKtM1Vbr/3b+AEMA7qLz7QjhgGJcie qp4b0gELjY1Oe9dBAXMiDwARAQABiQI8BBgBCAAmFiEEcM/SHOJt5ePBD8hO5T0WKDGD1rMF Alg2+xACGwwFCQlmAYAACgkQ5T0WKDGD1rOYSw/+P6fYSZjTJDAl9XNfXRjRRyJSfaw6N1pA Ahuu0MIa3djFRuFCrAHUaaFZf5V2iW5xhGnrhDwE1Ksf7tlstSne/G0a+Ef7vhUyeTn6U/0m +/BrsCsBUXhqeNuraGUtaleatQijXfuemUwgB+mE3B0SobE601XLo6MYIhPh8MG32MKO5kOY hB5jzyor7WoN3ETVNQoGgMzPVWIRElwpcXr+yGoTLAOpG7nkAUBBj9n9TPpSdt/npfok9ZfL /Q+ranrxb2Cy4tvOPxeVfR58XveX85ICrW9VHPVq9sJf/a24bMm6+qEg1V/G7u/AM3fM8U2m tdrTqOrfxklZ7beppGKzC1/WLrcr072vrdiN0icyOHQlfWmaPv0pUnW3AwtiMYngT96BevfA qlwaymjPTvH+cTXScnbydfOQW8220JQwykUe+sHRZfAF5TS2YCkQvsyf7vIpSqo/ttDk4+xc Z/wsLiWTgKlih2QYULvW61XU+mWsK8+ZlYUrRMpkauN4CJ5yTpvp+Orcz5KixHQmc5tbkLWf x0n1QFc1xxJhbzN+r9djSGGN/5IBDfUqSANC8cWzHpWaHmSuU3JSAMB/N+yQjIad2ztTckZY pwT6oxng29LzZspTYUEzMz3wK2jQHw+U66qBFk8whA7B2uAU1QdGyPgahLYSOa4XAEGb6wbI FEE= Message-ID: Date: Tue, 18 Jun 2019 07:37:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: <910a5806-9a08-adf4-4fba-d5ec2f5807ff@metux.net> Content-Language: en-US X-Provags-ID: V03:K1:/dnL+FrwD6jls44jfQSJs/QzVz23sTbNpFoph2pbpSY1cdxag3f asdWEq/53sHr3OhHx1Ap/QhZpRhExbf424lojEU4K3m8MNADyMlCTWYWWFrNNpyTsAoGvQ5 TGL01inXZF5zVirsmxlRygAjhhEVBVj1o0hNmtBTvDnDonuJS0/55NYuIHXJi4o0I94b+Ok JrX3GwDMsFMDA5s7m5NHg== X-UI-Out-Filterresults: notjunk:1;V03:K0:VyfW+UVXmpc=:MaB7ryAf38U/A1nVfGvG+3 O2Yzx6HK3nq0y23mrSDRLf/GTfr65LPKONvKGX+6suji17Bo9NeJozLfoU7krWkPjro4jugnx PsgoKrEdDbsTbGKllZTuu+fZfrwhkhmXshU6/vR7VtCvBqlJmxmp40WRQfTioZ/rOG8JvZDkO Hm3Cx/Pasdw9yFbVLQV/WPifSHN5EAQ7WUuj/BBDZsTLvSPFnKMSbDQT2VvxPCOgmoBxiBNC1 gV5PJe9bHAvgi/U1qjG8nFdGoObB4C6fdkC3Xn34QveUcQyYQ+nDHVsR1mGlTuwCoFH+rEGhC FAwwCZOaAauqLMPgjfV49ySYWC4MQDcLlY5CLyG0A1uGdDglj7FImYfV1H2WY1zaJG65qnWh6 GkPU3K+wnuUuVZAeV038+6X2yWEJ1fV+e1Ph0XP3Gg48iknNe2kj6c5qWJ7gxBOEjJB0ORxdu /MgPMTMqwE6XWFEVrdvznUrmO2gGFCyJ5w6sTAFC5n+ixuxbfL/ZXAa3582E60stuSmWlHIJt Y5061q12kyaU2WmzXb7JvXTOVFnrT3zjWPlRBhnKevmarwUAc+NngC14DysruZQre2fGx88UH /eyLAx2Rmf+GahCipU43F0snsdenazB2+9WVLvSu/lgiwo9eLA67hM9ory/n1I/Sol54hw5RG UorX1ltr8zRxomB5fQiFLtEFolNCMpYeaREjeNH27XTfTnyOnEK4DLAZPj3Jm6T/3XwMPJRNb hxPGrk/Up2n/XBSTPn8wKT9Z6WkZqCgZciQvhGNs7CbbhEaF08xdACjEhHz1jCgZ20+akfv+G j7+OboVHDySES0OYq1m+lLe2ua19D508tvQaaEJu6P0jssG2YWagiq1ktTPKf8Ga58dUrRkPG WvzQ9SVlV9IPAfAZYvXOp5Bxw0GXZQ2HW8KZXZJsNXjw7TXanVS+WnmHVsPFAMEgrgUAMmQa/ A5hdGhKhhDx4ZCCyRwE1wLb+qkywcqVBKKB/XNWvOKpXWphilW54Y X-Greylist: Sender IP whitelisted, Sender e-mail whitelisted, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Tue, 18 Jun 2019 07:38:03 +0200 (CEST) X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Tue, 18 Jun 2019 07:38:00 +0200 (CEST) X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 Cc: Michal Marek , Nicolas Palix , Linus Walleij , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko , cocci@systeme.lip6.fr Subject: Re: [Cocci] drivers: Inline code in devm_platform_ioremap_resource() from two functions X-BeenThere: cocci@systeme.lip6.fr X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: cocci-bounces@systeme.lip6.fr Errors-To: cocci-bounces@systeme.lip6.fr >> Two function calls were combined in this function implementation. >> Inline corresponding code so that extra error checks can be avoided here. > > What exactly is the purpose of this ? I suggest to take another look at the need and relevance of involved error checks in the discussed function combination. > Looks like a notable code duplication ... This can be. > I thought we usually try to reduce this, instead of introducing new ones. Would you like to check the software circumstances once more for the generation of a similar code structure by a C compiler (or optimiser)? Regards, Markus _______________________________________________ Cocci mailing list Cocci@systeme.lip6.fr https://systeme.lip6.fr/mailman/listinfo/cocci