Coccinelle archive on lore.kernel.org
 help / color / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Coccinelle <cocci@systeme.lip6.fr>
Subject: Re: [Cocci] Adding code after function return types with SmPL
Date: Tue, 8 Oct 2019 13:56:39 +0200
Message-ID: <f7713a17-43e4-04f3-58f9-6bbc2b95c21a@web.de> (raw)
In-Reply-To: <alpine.DEB.2.21.1910072244150.2578@hadrien>

>> Will the addition of such an annotation in a function declaration
>> become supported for the semantic patch language?
>
> Perhaps some day.

The desired modification for a known preprocessor symbol like “__must_check”
points software development challenges out.

But the following SmPL script variant gets accepted.

@addition@
identifier f;
type rt != void;
@@
 rt
+__attribute__ ((warn_unused_result))
 f(...);


Can further improvements become easier also for another transformation approach?

@replacement@
@@
-__attribute__ ((warn_unused_result))
+__must_check


elfring@Sonne:~/Projekte/Coccinelle/janitor> spatch --parse-cocci use_must_check5.cocci
init_defs_builtins: /usr/local/bin/../lib/coccinelle/standard.h
File "use_must_check5.cocci", line 3, column 1, charpos = 18
  around = '__attribute__',
  whole content = -__attribute__ ((warn_unused_result))


Would any additional error information be helpful here?

Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

  reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-07 12:48 Markus Elfring
2019-10-07 20:44 ` Julia Lawall
2019-10-08 11:56   ` Markus Elfring [this message]
2019-10-07 12:48 Markus Elfring

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7713a17-43e4-04f3-58f9-6bbc2b95c21a@web.de \
    --to=markus.elfring@web.de \
    --cc=cocci@systeme.lip6.fr \
    --cc=julia.lawall@lip6.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Coccinelle archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/cocci/0 cocci/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 cocci cocci/ https://lore.kernel.org/cocci \
		cocci@systeme.lip6.fr cocci@archiver.kernel.org
	public-inbox-index cocci

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/fr.lip6.systeme.cocci


AGPL code for this site: git clone https://public-inbox.org/ public-inbox