From: Markus Elfring <Markus.Elfring@web.de>
To: Yuan Can <yuancan@huawei.com>, cocci@inria.fr
Cc: Julia Lawall <Julia.Lawall@inria.fr>,
Nicolas Palix <nicolas.palix@imag.fr>,
kernel-janitors@vger.kernel.org
Subject: Re: [cocci] [PATCH 1/2] coccinelle: locks: add missing_mutex_init.cocci script
Date: Sat, 17 Sep 2022 08:40:20 +0200 [thread overview]
Message-ID: <fb101290-3ec7-9170-9fec-43e1b5f54c52@web.de> (raw)
In-Reply-To: <20220916061923.29759-1-yuancan@huawei.com>
> Find mutex used without init, and point out the
> place the mutex is allocated.
I find this commit message improvable.
Would you get into the development mood to generalise and extend the source code
search pattern besides proposed adjustments for the handling of spin locks?
How many data structures would need further initialisations after some memory
was allocated?
Regards,
Markus
next prev parent reply other threads:[~2022-09-17 6:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 6:19 [cocci] [PATCH 1/2] coccinelle: locks: add missing_mutex_init.cocci script Yuan Can
2022-09-16 6:19 ` [cocci] [PATCH 2/2] coccinelle: locks: add missing_spin_lock_init.cocci script Yuan Can
2022-09-16 14:43 ` [cocci] [PATCH 1/2] coccinelle: locks: add missing_mutex_init.cocci script Markus Elfring
2022-09-17 6:40 ` Markus Elfring [this message]
2022-09-18 19:39 ` Julia Lawall
2022-09-19 7:55 ` Yuan Can
2022-09-19 8:01 ` Julia Lawall
2022-09-19 8:10 ` Yuan Can
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb101290-3ec7-9170-9fec-43e1b5f54c52@web.de \
--to=markus.elfring@web.de \
--cc=Julia.Lawall@inria.fr \
--cc=cocci@inria.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=nicolas.palix@imag.fr \
--cc=yuancan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).