connman.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [PATCH] iwd: Fix timeout error on new connection
@ 2021-10-01 12:18 VAUTRIN Emmanuel (Canal Plus Prestataire)
  2021-10-01 13:29 ` Michael Nazzareno Trimarchi
  2021-10-04  6:34 ` Daniel Wagner
  0 siblings, 2 replies; 3+ messages in thread
From: VAUTRIN Emmanuel (Canal Plus Prestataire) @ 2021-10-01 12:18 UTC (permalink / raw)
  To: connman

Before connecting to a new network, the currenty connected one shall be
disconnected, what always failed with "Operation timeout" error, as
the disconnection seemed not completed, cm_network_disconnect
returning -EINPROGRESS on success.
---
 plugins/iwd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/plugins/iwd.c b/plugins/iwd.c
index c1c273ef4b3a..ec9a4574cf2d 100644
--- a/plugins/iwd.c
+++ b/plugins/iwd.c
@@ -317,7 +317,7 @@ static int cm_network_disconnect(struct connman_network *network)
 			NULL, cm_network_disconnect_cb, g_strdup(iwdn->path), g_free))
 		return -EIO;
 
-	return -EINPROGRESS;
+	return 0;
 }
 
 struct auto_connect_cb_data {
-- 
2.25.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] iwd: Fix timeout error on new connection
  2021-10-01 12:18 [PATCH] iwd: Fix timeout error on new connection VAUTRIN Emmanuel (Canal Plus Prestataire)
@ 2021-10-01 13:29 ` Michael Nazzareno Trimarchi
  2021-10-04  6:34 ` Daniel Wagner
  1 sibling, 0 replies; 3+ messages in thread
From: Michael Nazzareno Trimarchi @ 2021-10-01 13:29 UTC (permalink / raw)
  To: Emmanuel.VAUTRIN; +Cc: connman

On Fri, Oct 1, 2021 at 2:18 PM VAUTRIN Emmanuel (Canal Plus
Prestataire) <Emmanuel.VAUTRIN@cpexterne.org> wrote:
>
> Before connecting to a new network, the currenty connected one shall be
> disconnected, what always failed with "Operation timeout" error, as
> the disconnection seemed not completed, cm_network_disconnect
> returning -EINPROGRESS on success.
> ---
>  plugins/iwd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/plugins/iwd.c b/plugins/iwd.c
> index c1c273ef4b3a..ec9a4574cf2d 100644
> --- a/plugins/iwd.c
> +++ b/plugins/iwd.c
> @@ -317,7 +317,7 @@ static int cm_network_disconnect(struct connman_network *network)
>                         NULL, cm_network_disconnect_cb, g_strdup(iwdn->path), g_free))
>                 return -EIO;
>
> -       return -EINPROGRESS;
> +       return 0;
>  }
>

Reviewed-By: Michael Trimarchi <michael@amarulasolutions.com>

Michael
>  struct auto_connect_cb_data {
> --
> 2.25.1
>


-- 
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
michael@amarulasolutions.com
__________________________________

Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
info@amarulasolutions.com
www.amarulasolutions.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] iwd: Fix timeout error on new connection
  2021-10-01 12:18 [PATCH] iwd: Fix timeout error on new connection VAUTRIN Emmanuel (Canal Plus Prestataire)
  2021-10-01 13:29 ` Michael Nazzareno Trimarchi
@ 2021-10-04  6:34 ` Daniel Wagner
  1 sibling, 0 replies; 3+ messages in thread
From: Daniel Wagner @ 2021-10-04  6:34 UTC (permalink / raw)
  To: connman, VAUTRIN Emmanuel (Canal Plus Prestataire); +Cc: Daniel Wagner

On Fri, 1 Oct 2021 12:18:32 +0000, VAUTRIN Emmanuel (Canal Plus Prestataire) wrote:
> Before connecting to a new network, the currenty connected one shall be
> disconnected, what always failed with "Operation timeout" error, as
> the disconnection seemed not completed, cm_network_disconnect
> returning -EINPROGRESS on success.
> 

Applied, thanks!

[1/1] iwd: Fix timeout error on new connection
      commit: c07d5b11f122d2115b9f466f3106c144c315dede

Best regards,
-- 
Daniel Wagner <wagi@monom.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-10-04  6:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-01 12:18 [PATCH] iwd: Fix timeout error on new connection VAUTRIN Emmanuel (Canal Plus Prestataire)
2021-10-01 13:29 ` Michael Nazzareno Trimarchi
2021-10-04  6:34 ` Daniel Wagner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).