From: Daniel Wagner <wagi@monom.org>
To: connman@lists.linux.dev
Cc: Carsten Haitzler <raster@rasterman.com>, Daniel Wagner <wagi@monom.org>
Subject: [PATCH] service: Ask for password when using native autoconnect
Date: Wed, 23 Jun 2021 09:21:30 +0200 [thread overview]
Message-ID: <20210623072130.29852-1-wagi@monom.org> (raw)
When the native mode is activated we still need to ask for the
password if it's unknown.
Fixes: 561f318003c1 ("service: Teach autoconnect algorithm native mode")
---
Hi Carsten,
Sorry it took so long. There were some fallouts from recent gcc
warnings I had to look after first. Anyway, this patch fixed the
problem you reported for me. Please, let me know if there is still a
problem after this patch.
Thanks,
Daniel
src/service.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/service.c b/src/service.c
index 20917a8923a4..eb74a85d6e32 100644
--- a/src/service.c
+++ b/src/service.c
@@ -6756,7 +6756,8 @@ int __connman_service_connect(struct connman_service *service,
service->provider)
connman_provider_disconnect(service->provider);
- if (service->connect_reason == CONNMAN_SERVICE_CONNECT_REASON_USER) {
+ if (reason == CONNMAN_SERVICE_CONNECT_REASON_USER ||
+ reason == CONNMAN_SERVICE_CONNECT_REASON_NATIVE) {
if (err == -ENOKEY || err == -EPERM) {
DBusMessage *pending = NULL;
const char *dbus_sender = get_dbus_sender(service);
--
2.32.0
next reply other threads:[~2021-06-23 7:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 7:21 Daniel Wagner [this message]
2021-06-23 7:39 ` [PATCH] service: Ask for password when using native autoconnect Daniel Wagner
2021-06-24 8:45 ` Carsten Haitzler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210623072130.29852-1-wagi@monom.org \
--to=wagi@monom.org \
--cc=connman@lists.linux.dev \
--cc=raster@rasterman.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).