connman.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [PATCH] service: Fix default service update on ready state
@ 2021-06-23 12:18 VAUTRIN Emmanuel (Canal Plus Prestataire)
  2021-06-24  8:07 ` Daniel Wagner
  0 siblings, 1 reply; 12+ messages in thread
From: VAUTRIN Emmanuel (Canal Plus Prestataire) @ 2021-06-23 12:18 UTC (permalink / raw)
  To: connman

On a ready state transition, the default service shall be re-evaluated
after the preferred service reordering, before being processed.
---
 src/service.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/service.c b/src/service.c
index eb74a85d6e32..cb0103fd7221 100644
--- a/src/service.c
+++ b/src/service.c
@@ -6051,12 +6051,12 @@ static int service_indicate_state(struct connman_service *service)
 
 		service->new_service = false;
 
-		default_changed();
-
 		def_service = connman_service_get_default();
 
 		service_update_preferred_order(def_service, service, new_state);
 
+		default_changed();
+
 		__connman_service_set_favorite(service, true);
 
 		reply_pending(service, 0);
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2021-08-30  8:44 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-23 12:18 [PATCH] service: Fix default service update on ready state VAUTRIN Emmanuel (Canal Plus Prestataire)
2021-06-24  8:07 ` Daniel Wagner
2021-06-24  9:01   ` VAUTRIN Emmanuel (Canal Plus Prestataire)
2021-07-02  7:27     ` Daniel Wagner
2021-07-02  7:41       ` Daniel Wagner
2021-07-02 15:43         ` VAUTRIN Emmanuel (Canal Plus Prestataire)
2021-08-25 12:52           ` VAUTRIN Emmanuel (Canal Plus Prestataire)
2021-08-29 19:07             ` Daniel Wagner
2021-08-30  7:31               ` VAUTRIN Emmanuel (Canal Plus Prestataire)
2021-08-30  8:13                 ` Daniel Wagner
2021-08-30  8:28                   ` VAUTRIN Emmanuel (Canal Plus Prestataire)
2021-08-30  8:44                     ` Daniel Wagner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).