ConnMan network manager
 help / color / Atom feed
* [PATCH] agent: Always inform upper layer via callback
@ 2021-06-29  7:33 Daniel Wagner
  2021-06-29 10:48 ` John Keeping
  0 siblings, 1 reply; 3+ messages in thread
From: Daniel Wagner @ 2021-06-29  7:33 UTC (permalink / raw)
  To: connman; +Cc: John Keeping, Daniel Wagner

The upper state machine expects to be called in all cases. Do not
silenty eat up the callback.

Fixes: 8ea2d67a6e89 ("service: Complete only after user connection retries")
Reported by John Keeping
---
 src/agent.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/agent.c b/src/agent.c
index d6113af745fa..d4f9add478fb 100644
--- a/src/agent.c
+++ b/src/agent.c
@@ -366,9 +366,9 @@ static void report_error_reply(DBusMessage *reply, void *user_data)
 			retry = true;
 	}
 
+out:
 	report_error->callback(report_error->user_context, retry,
 			report_error->user_data);
-out:
 	g_free(report_error);
 }
 
-- 
2.32.0

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] agent: Always inform upper layer via callback
  2021-06-29  7:33 [PATCH] agent: Always inform upper layer via callback Daniel Wagner
@ 2021-06-29 10:48 ` John Keeping
  2021-06-30  7:35   ` Daniel Wagner
  0 siblings, 1 reply; 3+ messages in thread
From: John Keeping @ 2021-06-29 10:48 UTC (permalink / raw)
  To: Daniel Wagner; +Cc: connman

On Tue, 29 Jun 2021 09:33:26 +0200
Daniel Wagner <wagi@monom.org> wrote:

> The upper state machine expects to be called in all cases. Do not
> silenty eat up the callback.
> 
> Fixes: 8ea2d67a6e89 ("service: Complete only after user connection retries")
> Reported by John Keeping

Tested-by: John Keeping <john@metanate.com>

I've run through a few tests with this patch and it looks good!

Thanks for tracking down the issue here.


John

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] agent: Always inform upper layer via callback
  2021-06-29 10:48 ` John Keeping
@ 2021-06-30  7:35   ` Daniel Wagner
  0 siblings, 0 replies; 3+ messages in thread
From: Daniel Wagner @ 2021-06-30  7:35 UTC (permalink / raw)
  To: John Keeping; +Cc: connman

Hi John,

On Tue, Jun 29, 2021 at 11:48:42AM +0100, John Keeping wrote:
> On Tue, 29 Jun 2021 09:33:26 +0200
> Daniel Wagner <wagi@monom.org> wrote:
> 
> > The upper state machine expects to be called in all cases. Do not
> > silenty eat up the callback.
> > 
> > Fixes: 8ea2d67a6e89 ("service: Complete only after user connection retries")
> > Reported by John Keeping
> 
> Tested-by: John Keeping <john@metanate.com>
> 
> I've run through a few tests with this patch and it looks good!
> 
> Thanks for tracking down the issue here.

Thanks for testing. Patch applied.
Daniel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-29  7:33 [PATCH] agent: Always inform upper layer via callback Daniel Wagner
2021-06-29 10:48 ` John Keeping
2021-06-30  7:35   ` Daniel Wagner

ConnMan network manager

Archives are clonable:
	git clone --mirror https://lore.kernel.org/connman/0 connman/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 connman connman/ https://lore.kernel.org/connman \
		connman@lists.linux.dev
	public-inbox-index connman

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/dev.linux.lists.connman


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git