From: Daniel Wagner <wagi@monom.org>
To: connman@lists.linux.dev
Subject: Re: [PATCH] service: Let PreferredTechnologies overrule connected service sorting
Date: Fri, 2 Jul 2021 09:18:45 +0200 [thread overview]
Message-ID: <20210702071845.42llx43rhzubvqrs@beryllium.lan> (raw)
In-Reply-To: <20210621072036.302-1-wagi@monom.org>
On Mon, Jun 21, 2021 at 09:20:37AM +0200, Daniel Wagner wrote:
> When both services are in either READY or ONLINE state ConnMan will
> always return either the service in ONLINE state (this is the correct
> behavior) or when both services are in ONLINE state service_a
> first. PreferredTechnologies is ignored in this case.
>
> For configuration such as
>
> PreferredTechnologies = ethernet,wifi
> SingleConnectedTechnology = true
>
> ConnMan would almost never sort Ethernet before WiFi, as WiFi is likely
> to be in the ONLINE state. Hence the WiFi would stay on forever even
> though the Ethernet cable is plugged in (again).
>
> Place the service_compare_preferred() after the service->oder logic as
> this is used for split VPN setups which has higher priority in the
> sorting.
>
> As we place this call inside the 'is_connected' section where both
> service are in either READY or ONLINE state, it overrules the
> existing logic where the ONLINE service is preferred over the READY.
Patch applied.
prev parent reply other threads:[~2021-07-02 7:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 7:20 [PATCH] service: Let PreferredTechnologies overrule connected service sorting Daniel Wagner
2021-07-02 7:18 ` Daniel Wagner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210702071845.42llx43rhzubvqrs@beryllium.lan \
--to=wagi@monom.org \
--cc=connman@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).