From: Daniel Wagner <wagi@monom.org>
To: "VAUTRIN Emmanuel (Canal Plus Prestataire)"
<Emmanuel.VAUTRIN@cpexterne.org>
Cc: "connman@lists.linux.dev" <connman@lists.linux.dev>
Subject: Re: [PATCH] service: Ignore state information in service reordering
Date: Tue, 6 Jul 2021 09:19:11 +0200 [thread overview]
Message-ID: <20210706071911.6rl5b2nrooy6lchd@beryllium.lan> (raw)
In-Reply-To: <MRZP264MB154471078FD87663548DE9BB931F9@MRZP264MB1544.FRAP264.PROD.OUTLOOK.COM>
Hi Emmanuel,
On Fri, Jul 02, 2021 at 03:19:28PM +0000, VAUTRIN Emmanuel (Canal Plus Prestataire) wrote:
> If the state still matters for VPN part, maybe it will be cleaner
> to call is_connected() instead of checking the state itself.
Thanks for the explanation. Indeed if the service needs to be connected
then using is_connected() will clearly document this. I need do to test
this a bit first though.
Thannks,
Daniel
next prev parent reply other threads:[~2021-07-06 7:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 14:58 [PATCH] service: Ignore state information in service reordering VAUTRIN Emmanuel (Canal Plus Prestataire)
2021-07-02 7:53 ` Daniel Wagner
2021-07-02 8:13 ` VAUTRIN Emmanuel (Canal Plus Prestataire)
2021-07-02 8:37 ` Daniel Wagner
2021-07-02 15:19 ` VAUTRIN Emmanuel (Canal Plus Prestataire)
2021-07-06 7:19 ` Daniel Wagner [this message]
2021-08-25 12:30 ` VAUTRIN Emmanuel (Canal Plus Prestataire)
2021-08-29 18:48 ` Daniel Wagner
2021-08-30 7:26 ` VAUTRIN Emmanuel (Canal Plus Prestataire)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210706071911.6rl5b2nrooy6lchd@beryllium.lan \
--to=wagi@monom.org \
--cc=Emmanuel.VAUTRIN@cpexterne.org \
--cc=connman@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).