From: Daniel Wagner <email@example.com> To: "VAUTRIN Emmanuel (Canal Plus Prestataire)" <Emmanuel.VAUTRIN@cpexterne.org> Cc: "firstname.lastname@example.org" <email@example.com> Subject: Re: [PATCH] service: service_update_preferred_order cleanup Date: Mon, 26 Jul 2021 09:22:47 +0200 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <MRZP264MB15449923E85D932705598E8F93E29@MRZP264MB1544.FRAP264.PROD.OUTLOOK.COM> Hi Emmanuel, On Tue, Jul 20, 2021 at 12:31:25PM +0000, VAUTRIN Emmanuel (Canal Plus Prestataire) wrote: > Great to see you back, and hoping you will be able to check my other > pending patches, as I will generate a new release soon. Thanks. A few days holiday was really necessary. Though I am still pretty sluggish response time. Sorry about that. > > This is not just a pure refactoring change. Because > > > - if (default_service->type == tech_array[i]) > > - return -EALREADY; > > > is missing. This is only relevant for service_indicate_state() when we > > would ignore the new service. Hmm, not totally sure what it means. Did > > you figure out why this is not needed anymore? > In fact, it is not missing, I presume it is the case corresponding to: > service_compare_preferred(default_service, new_service) == -1, > which means the return -EALREADY; after the condition block of > if (service_compare_preferred(default_service, new_service) > 0). Ah, right. I'll apply the patch. Thanks, Daniel
next prev parent reply other threads:[~2021-07-26 7:28 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-19 9:01 VAUTRIN Emmanuel (Canal Plus Prestataire) 2021-07-20 12:14 ` Daniel Wagner 2021-07-20 12:31 ` VAUTRIN Emmanuel (Canal Plus Prestataire) 2021-07-26 7:22 ` Daniel Wagner [this message] 2021-07-26 7:52 ` VAUTRIN Emmanuel (Canal Plus Prestataire)
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --cc=Emmanuel.VAUTRIN@cpexterne.org \ --email@example.com \ --subject='Re: [PATCH] service: service_update_preferred_order cleanup' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).