Re: [connman v1] wifi: Set ieee80211w as required for WPA3-Personal-only mode

[Daniel Wagner <wagi@monom.org>]

Hi Ariel,

Thanks for tracking this! Just a stupid question:

On Mon, Aug 02, 2021 at 12:10:06PM -0300, Ariel D'Alessandro wrote:
> From wpa_supplicant docs [0] section "ieee80211w":
> 
>   "WPA3-Personal-only mode: ieee80211w=2 and key_mgmt=SAE".
> 
> This means that the parameter ieee80211w has to be set to 2 (required)
> if SAE is used. Fix it.
> 
> [0] https://w1.fi/cgit/hostap/plain/wpa_supplicant/wpa_supplicant.conf
> ---
>  plugins/wifi.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/plugins/wifi.c b/plugins/wifi.c
> index 578b4be7..02603e85 100644
> --- a/plugins/wifi.c
> +++ b/plugins/wifi.c
> @@ -2174,7 +2174,12 @@ static void ssid_init(GSupplicantSSID *ssid, struct connman_network *network)
>  	security = connman_network_get_string(network, "WiFi.Security");
>  	ssid->security = network_security(security);
>  	ssid->keymgmt = network_data->keymgmt;
> -	ssid->ieee80211w = G_SUPPLICANT_MFP_OPTIONAL;
> +	/*
> +	 * From wpa_supplicant docs:
> +	 * "WPA3-Personal-only mode: ieee80211w=2 and key_mgmt=SAE".
> +	 * Set ieee80211w as required, which is sent if SAE key is used.
> +	 */
> +	ssid->ieee80211w = G_SUPPLICANT_MFP_REQUIRED;

Should we check the keymgmt is SAE and only then set the ieee80211w
value?

Thanks,
Daniel