connman.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Jussi Laakkonen <jussi.laakkonen@jolla.com>
To: connman@lists.linux.dev
Subject: [PATCH 0/3] Improve invalid auth and disconnect notify on l2tp and pptp
Date: Fri, 13 Aug 2021 16:42:06 +0300	[thread overview]
Message-ID: <20210813134209.23253-1-jussi.laakkonen@jolla.com> (raw)

Both l2tp and pptp have the symptom that when authentication is invalid
the binary keeps on looping disconnect notify. As a solution to this the
task can be stopped to ensure that binary also dies. And to further make
the process better adapt similar connect done -approach that is used in,
e.g., OpenVPN to ensure the callback (vpn-provider.c:connect_cb()) will
get called only once.

This change makes both plugins to respond with 0 ("ok") only after the
notify from the binary is received that connection is established. Both
of the plugins did reply with 0 right after run_connect() which was not
the proper way.

Also add support for using ConnMan specific control file with xl2tpd
using -C switch. 

Jussi Laakkonen (2):
  l2tp: Improve invalid auth and disconnect notify, fix cb use
  pptp: Improve invalid auth and disconnect notify, fix cb use

Matt Vogt (1):
  l2tp: Create control file for xl2tpd

 vpn/plugins/l2tp.c | 133 +++++++++++++++++++++++++++++++--------------
 vpn/plugins/pptp.c | 127 ++++++++++++++++++++++++++++---------------
 2 files changed, 175 insertions(+), 85 deletions(-)

-- 
2.20.1


             reply	other threads:[~2021-08-13 13:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-13 13:42 Jussi Laakkonen [this message]
2021-08-13 13:42 ` [PATCH 1/3] l2tp: Create control file for xl2tpd Jussi Laakkonen
2021-08-13 13:42 ` [PATCH 2/3] l2tp: Improve invalid auth and disconnect notify, fix cb use Jussi Laakkonen
2021-08-13 13:42 ` [PATCH 3/3] pptp: " Jussi Laakkonen
2021-08-17  6:01 ` [PATCH 0/3] Improve invalid auth and disconnect notify on l2tp and pptp Daniel Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210813134209.23253-1-jussi.laakkonen@jolla.com \
    --to=jussi.laakkonen@jolla.com \
    --cc=connman@lists.linux.dev \
    --subject='Re: [PATCH 0/3] Improve invalid auth and disconnect notify on l2tp and pptp' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).