From: Daniel Wagner <wagi@monom.org>
To: Jussi Laakkonen <jussi.laakkonen@jolla.com>
Cc: connman@lists.linux.dev
Subject: Re: [PATCH 0/3] Improve invalid auth and disconnect notify on l2tp and pptp
Date: Tue, 17 Aug 2021 08:01:10 +0200 [thread overview]
Message-ID: <20210817060110.txygy4gtkke5gnng@carbon.lan> (raw)
In-Reply-To: <20210813134209.23253-1-jussi.laakkonen@jolla.com>
Hi Jussi,
On Fri, Aug 13, 2021 at 04:42:06PM +0300, Jussi Laakkonen wrote:
> Both l2tp and pptp have the symptom that when authentication is invalid
> the binary keeps on looping disconnect notify. As a solution to this the
> task can be stopped to ensure that binary also dies. And to further make
> the process better adapt similar connect done -approach that is used in,
> e.g., OpenVPN to ensure the callback (vpn-provider.c:connect_cb()) will
> get called only once.
>
> This change makes both plugins to respond with 0 ("ok") only after the
> notify from the binary is received that connection is established. Both
> of the plugins did reply with 0 right after run_connect() which was not
> the proper way.
>
> Also add support for using ConnMan specific control file with xl2tpd
> using -C switch.
Patches applied. Thanks!
Daniel
prev parent reply other threads:[~2021-08-17 6:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-13 13:42 [PATCH 0/3] Improve invalid auth and disconnect notify on l2tp and pptp Jussi Laakkonen
2021-08-13 13:42 ` [PATCH 1/3] l2tp: Create control file for xl2tpd Jussi Laakkonen
2021-08-13 13:42 ` [PATCH 2/3] l2tp: Improve invalid auth and disconnect notify, fix cb use Jussi Laakkonen
2021-08-13 13:42 ` [PATCH 3/3] pptp: " Jussi Laakkonen
2021-08-17 6:01 ` Daniel Wagner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210817060110.txygy4gtkke5gnng@carbon.lan \
--to=wagi@monom.org \
--cc=connman@lists.linux.dev \
--cc=jussi.laakkonen@jolla.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).