From: Daniel Wagner <wagi@monom.org>
To: connman@lists.linux.dev
Cc: Athimoolam Rajkumar <Rajkumar.A2@in.bosch.com>
Subject: Re: [PATCH] network: Do not disconnect decice on network connect
Date: Sun, 29 Aug 2021 21:37:52 +0200 [thread overview]
Message-ID: <20210829193752.kbxqmvvqr2nwvpeu@beryllium.lan> (raw)
In-Reply-To: <20210829193240.19095-1-wagi@monom.org>
On Sun, Aug 29, 2021 at 09:32:40PM +0200, Daniel Wagner wrote:
> Initially, commit 3b6dd9aa9030 ("Add support for disconnecting
> networks first") introduce the __connman_device_disconnect() in
> __connman_network_connect(). It was there to allow autoconnect to
> work. The initial code was checking if only one device should be
> connected:
>
> mode = connman_device_get_mode(network->device);
> if (mode == CONNMAN_DEVICE_MODE_NETWORK_SINGLE)
> __connman_device_disconnect(network->device);
>
> The service state machine has evolved over the time and this
> check is now part of the main service state machine. Though
> the code snippet in __connman_network_connect() was updated
> (the mode bits got removed) the disconnect was not removed.
>
> For 1:1 mapping between device and network this is no issues. But in
> the case of oFono we can have several APN/networks per device. Due to
> this disconnect call it's not possible to have several networks per
> device. Let's remove it.
I've updated the commit message slightly and applied the patch.
prev parent reply other threads:[~2021-08-29 19:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-29 19:32 [PATCH] network: Do not disconnect decice on network connect Daniel Wagner
2021-08-29 19:37 ` Daniel Wagner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210829193752.kbxqmvvqr2nwvpeu@beryllium.lan \
--to=wagi@monom.org \
--cc=Rajkumar.A2@in.bosch.com \
--cc=connman@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).