connman.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Daniel Wagner <wagi@monom.org>
To: Jussi Laakkonen <jussi.laakkonen@jolla.com>
Cc: connman@lists.linux.dev
Subject: Re: [PATCH v2 1/2] vpn-provider: Implement connmand online state checking
Date: Mon, 30 Aug 2021 10:11:32 +0200	[thread overview]
Message-ID: <20210830081132.kknkwxejkjek7vtx@carbon.lan> (raw)
In-Reply-To: <5eae634b-1abd-a752-7a11-9255b051ed8c@jolla.com>

Hi Jussi,

On Mon, Aug 30, 2021 at 09:59:59AM +0300, Jussi Laakkonen wrote:
> Sorry for the confusion. I think they're needed in order to let vpnd know
> the state connmand is in. The issue was in relying a VPN agent being present
> at all times which was a misunderstanding from our behalf because in our
> case VPNs cannot be connected without an agent.

Alright, I'll give the patches a quick test with my VPN use cases
later, just to make sure.

> So yes, I've updated the patches [PATCH v3 1/2] and [PATCH v2 2/2] last
> week, as I took another look on the old code noticed some issues to fix as
> well, which are included in the patches.

Ah okay.

> Do you want me to send them as one new patch set again or do you have some
> comments on the contents of the patches?

The look good IIRC. But yes please, send them as new patches again. If
possible not attached to this thread, this makes it way simpler to pick
them up from the mailing list.

Daniel

  reply	other threads:[~2021-08-30  8:11 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-17 15:14 [PATCH 0/2] Implement connmand state monitoring to vpnd Jussi Laakkonen
2021-08-17 15:14 ` [PATCH 1/2] vpn-provider: Implement connmand online state checking Jussi Laakkonen
2021-08-17 16:55   ` Daniel Wagner
2021-08-18  9:21     ` Jussi Laakkonen
2021-08-18 10:31   ` [PATCH v2 " Jussi Laakkonen
2021-08-19 12:11     ` Jussi Laakkonen
2021-08-19 12:30       ` Daniel Wagner
2021-08-19 12:38         ` Santtu Lakkala
2021-08-19 13:06           ` Daniel Wagner
2021-08-19 12:40         ` Jussi Laakkonen
2021-08-29 18:27           ` Daniel Wagner
2021-08-30  6:59             ` Jussi Laakkonen
2021-08-30  8:11               ` Daniel Wagner [this message]
2021-08-20 13:05   ` [PATCH v3 " Jussi Laakkonen
2021-08-17 15:14 ` [PATCH 2/2] vpn: Handle ENOLINK error in connect callback Jussi Laakkonen
2021-08-20 13:06   ` [PATCH v2 2/2] vpn: Refactor connect_reply() and handle NoCarrier -> ENOLINK error Jussi Laakkonen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210830081132.kknkwxejkjek7vtx@carbon.lan \
    --to=wagi@monom.org \
    --cc=connman@lists.linux.dev \
    --cc=jussi.laakkonen@jolla.com \
    --subject='Re: [PATCH v2 1/2] vpn-provider: Implement connmand online state checking' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).