connman.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: "Страхиња Радић" <contact@strahinja.org>
To: connman <connman@lists.linux.dev>
Subject: Re: [PATCH v1 2/2] service: Do not trigger wispr start when EnableOnlineCheck is disabled
Date: Mon, 30 Aug 2021 12:34:11 +0200	[thread overview]
Message-ID: <20210830103411.f33oibwwmk2sqmkl@prancingpony> (raw)
In-Reply-To: <20210830064403.5r3szonne7baipa2@carbon.lan>

[-- Attachment #1: Type: text/plain, Size: 1235 bytes --]

On 21/08/30 08:44, Daniel Wagner wrote:
> On Sun, Aug 29, 2021 at 10:08:49PM +0200, Страхиња Радић wrote:
> > On 21/08/29 09:53, Daniel Wagner wrote:
> > > Do not try to use wispr when the user has disabled the online check.
> > 
> > The patch you proposed seems fine to me. The gist is to let the user control if
> > the online check happens or not.
> 
> Could you give them a quick test if they work for you? Thanks!

I tested the patch with tcpdump, but unfortunately, it seems the connections are
still being made, even with EnableOnlineCheck=false, Enable6to4=false and
EnableOnlineToReadyTransition=false in /etc/connman/main.conf.

I first uninstalled and pkilled any existing versions of connman, then ensured I
applied both of your patches with git apply, ran make clean && make and make
install as root. Then I ran connmand as root and inside connmanctl:

connmanctl> enable wifi
connmanctl> agent on
connmanctl> connect <my_network>
<entered passphrase>

at the same time, I used tcpdump -i wlan0 > log.txt

and in the log I got a number of lines containing ipv4.connman.net.

Then I tried to apply my patch on top of your patches and repeat the process,
but got the same result.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2021-08-30 10:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-29 19:53 [PATCH v1 0/2] Disable online check for real Daniel Wagner
2021-08-29 19:53 ` [PATCH v1 1/2] service: Move wispr start code into helper Daniel Wagner
2021-08-29 19:53 ` [PATCH v1 2/2] service: Do not trigger wispr start when EnableOnlineCheck is disabled Daniel Wagner
2021-08-29 20:08   ` Страхиња Радић
2021-08-30  6:44     ` Daniel Wagner
2021-08-30 10:34       ` Страхиња Радић [this message]
2021-08-30 11:02         ` Страхиња Радић
2021-08-30 14:29           ` Daniel Wagner
2021-08-30 16:32 ` [PATCH v1 0/2] Disable online check for real Daniel Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210830103411.f33oibwwmk2sqmkl@prancingpony \
    --to=contact@strahinja.org \
    --cc=connman@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).