Re: [PATCH v2 0/2] Implement connmand state monitoring to vpnd

From: Daniel Wagner <wagi@monom.org>
To: Jussi Laakkonen <jussi.laakkonen@jolla.com>
Cc: connman@lists.linux.dev
Subject: Re: [PATCH v2 0/2] Implement connmand state monitoring to vpnd
Date: Tue, 31 Aug 2021 09:22:07 +0200	[thread overview]
Message-ID: <20210831072207.4gezq2fkmrdszac6@beryllium.lan> (raw)
In-Reply-To: <a0d28b35-d3d0-8454-c1ab-159c6ccd728f@jolla.com>

Hi Jussi,

On Tue, Aug 31, 2021 at 10:00:40AM +0300, Jussi Laakkonen wrote:
> > I fixed up some small whitespace issues in the first patch and dropped
> > the else block in do_connect(). Also added the 'void' argument to
> > get_connman_state() (all complains from checkpatch).
> > 
> 
> Ok, that is cool. Apparently my git did not find any whitespace issues with
> the patches as I do check that prior to sending, hmm.

No worries. I am using the whitespace mode in emacs to highlight issues,
but still I manage to add random whitespace damages. At least the end of
line stuff is pretty much gone with this help.

> Great, thanks. I'm curious, what kind of workflow you have now and what I
> should take account for prior to sending the patches. Does the b4 require
> that all of those patches are in the same thread or otherwise reset the
> versioning when re-sending the patches as a new set?

b4 is really targeting towards full series with consistent version
numbers in all patches posted as new mail thread. It understands the
versioning strategies and workflow. For example if I tell it to use v2
instead of v3, it will tell me, there is a v3 on the mailing list
(subject of the cover letter has to match). Overall, it's an absolute
awesome tool and I am glad we are hosted on lists.linux.dev, so that I
can use it. Konstantin did a very nice presentation recently on b4:

  https://people.kernel.org/monsieuricon/

Anyway the idea is that you have changes in your git tree and to create
a new posting do something along the lines of:

  git format-patch HEAD~~ -o ../patches/fancy-feature -v1 --cover-letter
  [edit cover letter]
  git send-email ../patches/fancy-feature/v1* --to=connman

and after reworking the commits, you do the same just use '-v2'.

BTW, if you want to add a change log per patch, you can use 'git notes'
and use 'git format-patch --notes' to add them. I haven't used this so
far, but looks very useful. Have to play with it :)

> Also, it wouldn't hurt to download Linus' checkpatch.pl :)

Yeah, just use it with a grain of salt. It tends to be too eager but it
helps to get some consistency into the code base.

Daniel