Re: [PATCH 3/3] iwd: Ensure hidden services connectable after removed

[Daniel Wagner <wagi@monom.org>]

On Fri, Oct 01, 2021 at 03:29:16PM +0000, VAUTRIN Emmanuel (Canal Plus Prestataire) wrote:
> Hidden services shall always be connectable, even after been removed.
> When a hidden service is removed, the associated iwd network stays as
> known and thus shall be connected as a visible network.
> ---
>  plugins/iwd.c | 71 +++++++++++++++++++++++++++++++++++++++------------
>  1 file changed, 54 insertions(+), 17 deletions(-)
> 
> diff --git a/plugins/iwd.c b/plugins/iwd.c
> index 961d53196207..9bd27e90c346 100644
> --- a/plugins/iwd.c
> +++ b/plugins/iwd.c
> @@ -140,6 +140,7 @@ struct iwd_station {
>  	bool scanning;
>  
>  	GHashTable *hidden_aps;
> +	GHashTable *hidden_networks;
>  	struct hidden_params *hidden;
>  	bool postpone_hidden;
>  };
> @@ -646,6 +647,37 @@ static void hidden_params_free(gpointer data)
>  	g_free(hidden);
>  }
>  
> +static int connect_hidden(struct iwd_station *iwds)
> +{
> +	struct iwd_network *iwdn;
> +	char *ssid_security;
> +	int err = 0;
> +
> +	ssid_security = g_strdup_printf("%s_%s",
> +				iwds->hidden->ssid, iwds->hidden->security);
> +	iwdn = g_hash_table_lookup(iwds->hidden_networks, ssid_security);
> +	if (iwdn) {
> +		err = connman_network_connect_hidden(iwdn->network,
> +				iwds->hidden->identity,
> +				iwds->hidden->passphrase,
> +				iwds->hidden->user_data);
> +		iwds->hidden->user_data = NULL;
> +	if (err == -EINPROGRESS)
> +		err = 0;

You could do a 'return 0' here.