connman.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Daniel Wagner <wagi@monom.org>
To: Michael Trimarchi <michael@amarulasolutions.com>
Cc: connman@lists.linux.dev
Subject: Re: [PATCH 1/4] tethering: Reduce the number of parameters of tech_set_tethering
Date: Fri, 15 Oct 2021 08:51:59 +0200	[thread overview]
Message-ID: <20211015065159.5dz6dg743ykx5rn7@beryllium.lan> (raw)
In-Reply-To: <20211007213021.58712-1-michael@amarulasolutions.com>

Hi Michael,

On Thu, Oct 07, 2021 at 11:30:18PM +0200, Michael Trimarchi wrote:
> connman_echnology is an opaque type but has all the parameters to handle
> the connection. Those parameters are only used in wifi tethering
> one and not in other technologies
> 
> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> ---
>  include/technology.h |  8 ++++++--
>  plugins/bluetooth.c  |  1 -
>  plugins/ethernet.c   |  1 -
>  plugins/gadget.c     |  1 -
>  plugins/wifi.c       | 25 ++++++++++++-------------

plugins/iwd.c was missing. I updated it accordingly.

>  src/technology.c     | 20 ++++++++++++--------
>  6 files changed, 30 insertions(+), 26 deletions(-)
> 
> diff --git a/include/technology.h b/include/technology.h
> index 7508a9a1..7febd109 100644
> --- a/include/technology.h
> +++ b/include/technology.h
> @@ -44,8 +44,13 @@ void connman_technology_regdom_notify(struct connman_technology *technology,
>  
>  enum connman_service_type connman_technology_get_type
>  				(struct connman_technology *technology);
> +
> +bool connman_get_wifi_tethering_from_technology(const struct connman_technology *technology,
> +						const char **ssid, const char **psk);
> +
>  bool connman_technology_get_wifi_tethering(const char **ssid,
> -							const char **psk);
> +						const char **psk);
> +

I decided to not to add connman_get_wifi_tethering_from_technology() and
instead just extend connman_technology_get_wifi_tethering() as the newly
introduced function name is awkward and doesn't fit. Furthermore, it's
just a simple wrapper.

Patch applied.

Thanks,
Daniel


      parent reply	other threads:[~2021-10-15  6:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-07 21:30 Michael Trimarchi
2021-10-07 21:30 ` [PATCH 2/4] tethering: Add possibility to configure the access point frequency Michael Trimarchi
2021-10-15  6:52   ` Daniel Wagner
2021-10-15  7:01     ` Michael Nazzareno Trimarchi
2021-10-15  7:04       ` Daniel Wagner
2021-10-15  7:09         ` Michael Nazzareno Trimarchi
2021-10-15  7:18           ` Daniel Wagner
2021-10-07 21:30 ` [PATCH 3/4] tethering: Add TetheringFreq parameter documentation Michael Trimarchi
2021-10-07 21:30 ` [PATCH 4/4] client: Update the connmactl to support optional tethering channel Michael Trimarchi
2021-10-14  6:31 ` [PATCH 1/4] tethering: Reduce the number of parameters of tech_set_tethering Julien Barrault
2021-10-15  6:53   ` Daniel Wagner
2021-10-22 15:20     ` Julien Barrault
2021-10-22 15:33       ` Michael Nazzareno Trimarchi
2021-10-15  6:51 ` Daniel Wagner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211015065159.5dz6dg743ykx5rn7@beryllium.lan \
    --to=wagi@monom.org \
    --cc=connman@lists.linux.dev \
    --cc=michael@amarulasolutions.com \
    --subject='Re: [PATCH 1/4] tethering: Reduce the number of parameters of tech_set_tethering' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).