Re: [PATCH 1/4] tethering: Reduce the number of parameters of tech_set_tethering

[Daniel Wagner <wagi@monom.org>]

Hi Michael,

On Thu, Oct 07, 2021 at 11:30:18PM +0200, Michael Trimarchi wrote:
> connman_echnology is an opaque type but has all the parameters to handle
> the connection. Those parameters are only used in wifi tethering
> one and not in other technologies
> 
> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> ---
>  include/technology.h |  8 ++++++--
>  plugins/bluetooth.c  |  1 -
>  plugins/ethernet.c   |  1 -
>  plugins/gadget.c     |  1 -
>  plugins/wifi.c       | 25 ++++++++++++-------------

plugins/iwd.c was missing. I updated it accordingly.

>  src/technology.c     | 20 ++++++++++++--------
>  6 files changed, 30 insertions(+), 26 deletions(-)
> 
> diff --git a/include/technology.h b/include/technology.h
> index 7508a9a1..7febd109 100644
> --- a/include/technology.h
> +++ b/include/technology.h
> @@ -44,8 +44,13 @@ void connman_technology_regdom_notify(struct connman_technology *technology,
>  
>  enum connman_service_type connman_technology_get_type
>  				(struct connman_technology *technology);
> +
> +bool connman_get_wifi_tethering_from_technology(const struct connman_technology *technology,
> +						const char **ssid, const char **psk);
> +
>  bool connman_technology_get_wifi_tethering(const char **ssid,
> -							const char **psk);
> +						const char **psk);
> +

I decided to not to add connman_get_wifi_tethering_from_technology() and
instead just extend connman_technology_get_wifi_tethering() as the newly
introduced function name is awkward and doesn't fit. Furthermore, it's
just a simple wrapper.

Patch applied.

Thanks,
Daniel