From: Daniel Wagner <wagi@monom.org>
To: "VAUTRIN Emmanuel (Canal Plus Prestataire)"
<Emmanuel.VAUTRIN@cpexterne.org>
Cc: "connman@lists.linux.dev" <connman@lists.linux.dev>
Subject: Re: [PATCH v1 0/3] Fixup clang error messages
Date: Fri, 15 Oct 2021 11:25:11 +0200 [thread overview]
Message-ID: <20211015092511.lipwpb6xqjgyahor@carbon.lan> (raw)
In-Reply-To: <MRZP264MB154433CE695C2E97B02500D193B99@MRZP264MB1544.FRAP264.PROD.OUTLOOK.COM>
On Fri, Oct 15, 2021 at 08:55:10AM +0000, VAUTRIN Emmanuel (Canal Plus Prestataire) wrote:
> > Based on Emmanuel's patches[1] I tried to get clang to compile
> > ConnMan. -Wcast-align seems a bit too much for clang so I disabled it
> > for clang. The rest are couple of fallouts. Nothing serious. Though I
> > was not able to reproduce the maybe-unitialized warnings.
> Strange that you have not faced the same compilation issues.
This is way it's good not all have the same toolchain running. So I am
not completely surprised I don't see it.
> Maybe it is related to the Yocto integration I am using.
I am using the clang from my distro (Tubmleweed). Maybe clang can be
configured to behave differently. No idea.
> Have you tried to activate maybe-uninitialized warning or do you think it is
> not necessary to check this one before providing patches?
Yes, I added maybe-uninitialized but still no report from clang. It's
totally fine to use different compile flags. But make sure you add them
to your commit message. For example the align-cast errors reported by
clang is something I'd likely be ignoring. Some of them make sense to
address but some are not in our hands, e.g. system include headers.
IIRC, your patch fixes a real problem. I was unhappy on the commit
message and all in on patch.
prev parent reply other threads:[~2021-10-15 9:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 7:06 [PATCH v1 0/3] Fixup clang error messages Daniel Wagner
2021-10-12 7:06 ` [PATCH v1 1/3] build: Only enable -Wcast-align for gcc Daniel Wagner
2021-10-12 7:06 ` [PATCH v1 2/3] inet: Remove unused ipv6_addr_advert_mult Daniel Wagner
2021-10-12 7:06 ` [PATCH v1 3/3] gsupplicant: Fix error return type Daniel Wagner
2021-10-15 7:03 ` [PATCH v1 0/3] Fixup clang error messages Daniel Wagner
2021-10-15 8:55 ` VAUTRIN Emmanuel (Canal Plus Prestataire)
2021-10-15 9:25 ` Daniel Wagner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211015092511.lipwpb6xqjgyahor@carbon.lan \
--to=wagi@monom.org \
--cc=Emmanuel.VAUTRIN@cpexterne.org \
--cc=connman@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).