From: Daniel Wagner <wagi@monom.org>
To: connman@lists.linux.dev, Emmanuel VAUTRIN <emmanuel.vautrin@gmail.com>
Cc: Emmanuel VAUTRIN <Emmanuel.VAUTRIN@cpexterne.org>
Subject: Re: [PATCH 1/3] build: Cleanup of iwd provision_service_wifi()
Date: Wed, 20 Oct 2021 08:13:13 +0200 [thread overview]
Message-ID: <20211020061313.y66v5tgyv5li3qjv@carbon.lan> (raw)
In-Reply-To: <163471007023.5510.6880163764440514969.b4-ty@monom.org>
Hi Emmanual
On Wed, Oct 20, 2021 at 08:08:16AM +0200, Daniel Wagner wrote:
> On Mon, 18 Oct 2021 10:16:00 +0200, Emmanuel VAUTRIN wrote:
Thanks for updating your setup. I could pick up these patches via b4 and
process them easily. Really appreciated you took the time to setup it!
> > gcc reports with:
Ahaaa, I thought -Werror=maybe-uninitialized was for clang. Stupid me...
> > src/config.c: In function 'try_provision_service':
> > src/config.c:1421:3: error: 'ssid' may be used uninitialized in this
> > function [-Werror=maybe-uninitialized]
> > 1421 | provision_service_wifi(config, service, network,
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > 1422 | ssid, ssid_len);
> > | ~~~~~~~~~~~~~~~
> >
> > [...]
>
> Applied, thanks!
>
> [1/3] build: Cleanup of iwd provision_service_wifi()
> commit: a75b0693ace6e226cfc15e0a1534f7e2cbf3f47c
> [2/3] build: Fix uninitialized errors in iptables tests
> commit: dff52fff9b26065e433fedb73ed259d82f06ac73
> [3/3] build: Fix uninitialized false positive in dnsproxy
> commit: fdbdaab520726afdb07cc042eb159392aa4fc9d6
BTW, I updated the prefix of the commit title, so the SHAs don't match.
Thanks,
Daniel
next prev parent reply other threads:[~2021-10-20 6:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 8:16 [PATCH 1/3] build: Cleanup of iwd provision_service_wifi() Emmanuel VAUTRIN
2021-10-18 8:16 ` [PATCH 2/3] build: Fix uninitialized errors in iptables tests Emmanuel VAUTRIN
2021-10-18 8:16 ` [PATCH 3/3] build: Fix uninitialized false positive in dnsproxy Emmanuel VAUTRIN
2021-10-20 6:08 ` [PATCH 1/3] build: Cleanup of iwd provision_service_wifi() Daniel Wagner
2021-10-20 6:13 ` Daniel Wagner [this message]
2021-10-20 14:31 ` VAUTRIN Emmanuel (Canal Plus Prestataire)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211020061313.y66v5tgyv5li3qjv@carbon.lan \
--to=wagi@monom.org \
--cc=Emmanuel.VAUTRIN@cpexterne.org \
--cc=connman@lists.linux.dev \
--cc=emmanuel.vautrin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).