From: Jussi Laakkonen <jussi.laakkonen@jolla.com>
To: connman@lists.linux.dev
Subject: [PATCH v1 0/2] Improve OpenVPN configuration value processing
Date: Tue, 16 Nov 2021 17:14:15 +0200 [thread overview]
Message-ID: <20211116151417.14827-1-jussi.laakkonen@jolla.com> (raw)
Rework how OpenVPN processes the configuration values by introducing a
more clear way to classify different types of options. This makes it possible
to add options that may have a value or can be used without a value thus,
resorting to default value set for the option. Also the --auth-user-pass
and alike options having a special value are handled in cleaner way.
Motivation for this was that the --comp-lzo option was not processed
correctly with its value, and even though being listed as deprecated some
OpenVPN providers use the value. Omitting this option even though it was
required caused issues with both UDP and TCP VPNs:
write to TUN/TAP : Invalid argument (code=22)
after which OpenVPN silently restarts itself.
Jussi Laakkonen (2):
vpn-provider: Support checking if provider setting key exists.
openvpn: Improve configuration value processing
vpn/plugins/openvpn.c | 119 ++++++++++++++++++++++++++----------------
vpn/vpn-provider.c | 6 +++
vpn/vpn-provider.h | 2 +
3 files changed, 83 insertions(+), 44 deletions(-)
--
2.20.1
next reply other threads:[~2021-11-16 15:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 15:14 Jussi Laakkonen [this message]
2021-11-16 15:14 ` [PATCH v1 1/2] vpn-provider: Support checking if provider setting key exists Jussi Laakkonen
2021-11-16 15:14 ` [PATCH v1 2/2] openvpn: Improve configuration value processing Jussi Laakkonen
2021-11-18 21:02 ` [PATCH v1 0/2] Improve OpenVPN " Daniel Wagner
2021-11-19 8:09 ` Jussi Laakkonen
2021-11-19 8:30 ` Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211116151417.14827-1-jussi.laakkonen@jolla.com \
--to=jussi.laakkonen@jolla.com \
--cc=connman@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).