connman.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Daniel Wagner <wagi@monom.org>
To: connman@lists.linux.dev
Cc: Daniel Wagner <wagi@monom.org>
Subject: [PATCH 0/5] dnsproxy: Add input validation checks
Date: Tue, 25 Jan 2022 10:00:21 +0100	[thread overview]
Message-ID: <20220125090026.5108-1-wagi@monom.org> (raw)

Matthias Gerstner was busy testing the dnsproxy code and found a bunch
of bugs. With a lot of input and help from him we came up with the
following patches.

dnsproxy.c is in a pretty bad shape and needs a complete rewrite with
proper tests added. This will take time and brave soul to do so.
Though things aren't that bad as there is the option to use
systemd-resolved as DNS proxy. I haven't looked at the code of it but
I am pretty sure it is way better than dnsproxy.c :)

Anyway, I'd like to thank Matthias for his excellent support and
contributions fixing up these bugs.

Thanks,
Daniel

Daniel Wagner (2):
  main: Use g_strdup for online_check_ipv{4,6}_url config
  dnsproxy: Validate input data before using them

Matthias Gerstner (3):
  dnsproxy: Update TCP length header
  dnsproxy: Avoid 100 % busy loop in TCP server case
  dnsproxy: Keep timeout in TCP case even after connection is
    established

 src/dnsproxy.c | 51 ++++++++++++++++++++++++++++++++++++++++----------
 src/main.c     | 11 +++++++++--
 2 files changed, 50 insertions(+), 12 deletions(-)

-- 
2.34.1


             reply	other threads:[~2022-01-25  9:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-25  9:00 Daniel Wagner [this message]
2022-01-25  9:00 ` [PATCH 1/5] main: Use g_strdup for online_check_ipv{4,6}_url config Daniel Wagner
2022-01-25  9:00 ` [PATCH 2/5] dnsproxy: Update TCP length header Daniel Wagner
2022-01-25  9:00 ` [PATCH 3/5] dnsproxy: Validate input data before using them Daniel Wagner
2022-01-25  9:00 ` [PATCH 4/5] dnsproxy: Avoid 100 % busy loop in TCP server case Daniel Wagner
2022-01-25  9:00 ` [PATCH 5/5] dnsproxy: Keep timeout in TCP case even after connection is established Daniel Wagner
2022-01-25  9:10 ` [PATCH 0/5] dnsproxy: Add input validation checks Daniel Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220125090026.5108-1-wagi@monom.org \
    --to=wagi@monom.org \
    --cc=connman@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).