From: Daniel Wagner <wagi@monom.org>
To: "VAUTRIN Emmanuel (Canal Plus Prestataire)"
<Emmanuel.VAUTRIN@cpexterne.org>
Cc: "connman@lists.linux.dev" <connman@lists.linux.dev>
Subject: Re: [PATCH v2] iwd: Always disconnect connection completely
Date: Tue, 25 Jan 2022 10:50:14 +0100 [thread overview]
Message-ID: <20220125095014.eafpxusdnc62mbjp@beryllium.lan> (raw)
In-Reply-To: <MRZP264MB154447165B86A88033C533B8935E9@MRZP264MB1544.FRAP264.PROD.OUTLOOK.COM>
Hi Emmanuel,
On Mon, Jan 24, 2022 at 09:06:27AM +0000, VAUTRIN Emmanuel (Canal Plus Prestataire) wrote:
> Before being able to connect to a new network, finish disconnecting
> the old connection. The network can change while the
> cm_network_disconnect_cb is scheduled.
>
> Commit 024309a9e04a ("wifi: Reset disconnecting status of any network")
> Commit 795883e98eba ("wifi: Check valid network in disconnect callback")
> Commit dd86f09107e8 ("wifi: Always disconnect connection completely")
I haven't made my mind up yet on this one. The problem I see with this
is that we start add glue logic which is hard to follow and I am not
sure if this is the right place for it. If you have some more info
what's happening I would love to hear.
Daniel
next prev parent reply other threads:[~2022-01-25 9:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220124085336.3641685-1-Emmanuel.VAUTRIN@cpexterne.org>
2022-01-24 9:06 ` [PATCH v2] iwd: Always disconnect connection completely VAUTRIN Emmanuel (Canal Plus Prestataire)
2022-01-25 9:50 ` Daniel Wagner [this message]
2022-01-25 10:43 ` VAUTRIN Emmanuel (Canal Plus Prestataire)
2022-01-25 10:57 ` Daniel Wagner
2022-01-25 16:25 ` Denis Kenzior
2022-02-08 15:33 ` VAUTRIN Emmanuel (Canal Plus Prestataire)
2022-02-21 9:10 ` VAUTRIN Emmanuel (Canal Plus Prestataire)
2022-02-21 16:44 ` Daniel Wagner
2022-02-21 16:53 ` VAUTRIN Emmanuel (Canal Plus Prestataire)
2022-02-27 18:09 ` Daniel Wagner
2022-02-28 11:21 ` VAUTRIN Emmanuel (Canal Plus Prestataire)
2022-03-04 8:05 ` Daniel Wagner
2022-03-04 8:51 ` VAUTRIN Emmanuel (Canal Plus Prestataire)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220125095014.eafpxusdnc62mbjp@beryllium.lan \
--to=wagi@monom.org \
--cc=Emmanuel.VAUTRIN@cpexterne.org \
--cc=connman@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).