connman.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: matthias.gerstner@suse.de
To: connman@lists.linux.dev
Subject: [PATCH 1/7] dnsproxy: remove unused domain parameter from `remove_server()`
Date: Thu, 17 Feb 2022 12:31:07 +0100	[thread overview]
Message-ID: <20220217113113.24088-2-matthias.gerstner@suse.de> (raw)
In-Reply-To: <20220217113113.24088-1-matthias.gerstner@suse.de>

From: Matthias Gerstner <matthias.gerstner@suse.de>

---
 src/dnsproxy.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/dnsproxy.c b/src/dnsproxy.c
index cf1d36c7..ad8c5da2 100644
--- a/src/dnsproxy.c
+++ b/src/dnsproxy.c
@@ -2843,8 +2843,7 @@ int __connman_dnsproxy_append(int index, const char *domain,
 	return 0;
 }
 
-static void remove_server(int index, const char *domain,
-			const char *server, int protocol)
+static void remove_server(int index, const char *server, int protocol)
 {
 	struct server_data *data;
 	GSList *list;
@@ -2885,8 +2884,8 @@ int __connman_dnsproxy_remove(int index, const char *domain,
 	if (g_str_equal(server, "::1"))
 		return -ENODEV;
 
-	remove_server(index, domain, server, IPPROTO_UDP);
-	remove_server(index, domain, server, IPPROTO_TCP);
+	remove_server(index, server, IPPROTO_UDP);
+	remove_server(index, server, IPPROTO_TCP);
 
 	return 0;
 }
-- 
2.34.1


  reply	other threads:[~2022-02-17 11:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-17 11:31 dnsproxy: some initial refactoring and integration test matthias.gerstner
2022-02-17 11:31 ` matthias.gerstner [this message]
2022-02-17 11:31 ` [PATCH 2/7] dnsproxy: remove unnecessarily shadowed variable matthias.gerstner
2022-02-17 11:31 ` [PATCH 3/7] dnsproxy: protocol_offset: remove error return case and return size_t matthias.gerstner
2022-02-21  8:49   ` Daniel Wagner
2022-02-17 11:31 ` [PATCH 4/7] .gitignore: also ignore backup configure script matthias.gerstner
2022-02-21  8:49   ` Daniel Wagner
2022-02-17 11:31 ` [PATCH 5/7] dnsproxy: support programmatic configuration of the default listen port matthias.gerstner
2022-02-17 11:31 ` [PATCH 6/7] dnsproxy-test: support command line specification of dnsproxy port matthias.gerstner
2022-02-17 11:31 ` [PATCH 7/7] dnsproxy: add standalone test version of dnsproxy and a test script for it matthias.gerstner
2022-02-21  8:48   ` Daniel Wagner
2022-02-28 13:19     ` dnsproxy: some initial refactoring and integration test matthias.gerstner
2022-02-28 13:19       ` [PATCH] dnsproxy: add standalone test version of dnsproxy and a test script for it matthias.gerstner
2022-03-04  8:50         ` Daniel Wagner
2022-02-21  8:51 ` dnsproxy: some initial refactoring and integration test Daniel Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220217113113.24088-2-matthias.gerstner@suse.de \
    --to=matthias.gerstner@suse.de \
    --cc=connman@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).