connman.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Daniel Wagner <wagi@monom.org>
To: Jakub Jirutka <jakub@jirutka.cz>
Cc: connman@lists.linux.dev
Subject: Re: [PATCH] timeserver: Add EnableNTPClient option to connman.conf
Date: Thu, 14 Apr 2022 21:05:15 +0200	[thread overview]
Message-ID: <20220414190515.toyyuk55zylrq25g@beryllium.lan> (raw)
In-Reply-To: <20220414001208.4026-1-jakub@jirutka.cz>

Hi Jakub,

On Thu, Apr 14, 2022 at 02:12:08AM +0200, Jakub Jirutka wrote:
> The builtin NTP client can now only be disabled via DBus or manually
> editing the state file /var/lib/connman/settings
> (`TimeUpdates = "manual"`). These options are not optimal for a setup
> where a standalone NTP client is used.
> 
> The approach for disabling NTP client (in timeserver.c) is based on the
> existing code for handling state setting `TimeUpdates = "manual"`.
> 
> I originally wanted to implement this using CLI option, just
> like --nodnsproxy, but after reading the message from Daniel Wagner
> on ML (Unification to connman configuration? Now it 3 separated places)
> regarding --nodnsproxy, I concluded that the config file is preferred.

I am not against the idea to have the default configurable via the
config file, but please make just the default behavior so that the D-Bus
API still works (unless I read your patch wrong).

Thanks,
Daniel

  reply	other threads:[~2022-04-14 19:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-14  0:12 [PATCH] timeserver: Add EnableNTPClient option to connman.conf Jakub Jirutka
2022-04-14 19:05 ` Daniel Wagner [this message]
2022-04-15 22:51   ` Jakub Jirutka
2022-05-16  6:47     ` Daniel Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220414190515.toyyuk55zylrq25g@beryllium.lan \
    --to=wagi@monom.org \
    --cc=connman@lists.linux.dev \
    --cc=jakub@jirutka.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).