connman.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Andrei Datcu <datcuandrei@gmail.com>
To: connman@lists.linux.dev
Subject: Manager::ServicesChanged properties
Date: Thu, 3 Jun 2021 15:04:10 +0300	[thread overview]
Message-ID: <CAAmFs7nJNeKJG0Bitgwy4dpautH9hV1pCiSRiHoj8fX_b5ksvg@mail.gmail.com> (raw)

Currently, the documentation states that

The dictionary with the properties might be empty in case none of
the properties have changed. Or only contains the
properties that have changed.
For newly added services the whole set of properties will be present.


Yet, the final paragraph also says:

This signal will only be triggered when the sort
order of the service list or the number of services
changes. It will not be emitted if only a property
of the service object changes.


Combining the two rules, I understand that the props dictionary is
either empty (for existing services) or it either contains the entire
props dict of the newly added service.

My question:

Since by inspecting the code (service.c::service_send_changed) this
seems to currently be the case, is there any particular reason why the
documentation doesn't state it explicitly? Was there ever the
possibility to get a partial dictionary? If not, would you consider a
patch to the documentation to make it clearer for the future?

Thanks,

Andrei Datcu

             reply	other threads:[~2021-06-03 12:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-03 12:04 Andrei Datcu [this message]
2021-06-09  6:54 ` Manager::ServicesChanged properties Daniel Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAmFs7nJNeKJG0Bitgwy4dpautH9hV1pCiSRiHoj8fX_b5ksvg@mail.gmail.com \
    --to=datcuandrei@gmail.com \
    --cc=connman@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).