connman.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Michael Nazzareno Trimarchi <michael@amarulasolutions.com>
To: Emmanuel.VAUTRIN@cpexterne.org
Cc: "connman@lists.linux.dev" <connman@lists.linux.dev>
Subject: Re: [PATCH] iwd: Fix timeout error on new connection
Date: Fri, 1 Oct 2021 15:29:07 +0200	[thread overview]
Message-ID: <CAOf5uwnD30ADMg4_EraiZodqk8cP2wH9Hc2a0QHPCJeY5__evg@mail.gmail.com> (raw)
In-Reply-To: <MRZP264MB1544D8BAECCC6E7436D85D4F93AB9@MRZP264MB1544.FRAP264.PROD.OUTLOOK.COM>

On Fri, Oct 1, 2021 at 2:18 PM VAUTRIN Emmanuel (Canal Plus
Prestataire) <Emmanuel.VAUTRIN@cpexterne.org> wrote:
>
> Before connecting to a new network, the currenty connected one shall be
> disconnected, what always failed with "Operation timeout" error, as
> the disconnection seemed not completed, cm_network_disconnect
> returning -EINPROGRESS on success.
> ---
>  plugins/iwd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/plugins/iwd.c b/plugins/iwd.c
> index c1c273ef4b3a..ec9a4574cf2d 100644
> --- a/plugins/iwd.c
> +++ b/plugins/iwd.c
> @@ -317,7 +317,7 @@ static int cm_network_disconnect(struct connman_network *network)
>                         NULL, cm_network_disconnect_cb, g_strdup(iwdn->path), g_free))
>                 return -EIO;
>
> -       return -EINPROGRESS;
> +       return 0;
>  }
>

Reviewed-By: Michael Trimarchi <michael@amarulasolutions.com>

Michael
>  struct auto_connect_cb_data {
> --
> 2.25.1
>


-- 
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
michael@amarulasolutions.com
__________________________________

Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
info@amarulasolutions.com
www.amarulasolutions.com

  reply	other threads:[~2021-10-01 13:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-01 12:18 VAUTRIN Emmanuel (Canal Plus Prestataire)
2021-10-01 13:29 ` Michael Nazzareno Trimarchi [this message]
2021-10-04  6:34 ` Daniel Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOf5uwnD30ADMg4_EraiZodqk8cP2wH9Hc2a0QHPCJeY5__evg@mail.gmail.com \
    --to=michael@amarulasolutions.com \
    --cc=Emmanuel.VAUTRIN@cpexterne.org \
    --cc=connman@lists.linux.dev \
    --subject='Re: [PATCH] iwd: Fix timeout error on new connection' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).