From: "VAUTRIN Emmanuel (Canal Plus Prestataire)" <Emmanuel.VAUTRIN@cpexterne.org>
To: "Lukáš Karas" <lukas.karas@centrum.cz>,
"connman@lists.linux.dev" <connman@lists.linux.dev>
Subject: RE: [PATCH] dnsproxy: Suppress GCC warning stringop-overflow
Date: Tue, 15 Jun 2021 09:51:39 +0000 [thread overview]
Message-ID: <PR1PR02MB479414C6FC276ADEE776118493309@PR1PR02MB4794.eurprd02.prod.outlook.com> (raw)
> Recently added check for buffer size breaks build
> with GCC 10.3.0, its internal analysis suspect that code
> is not correct. Build fails with error:
> '__builtin_strncpy' specified bound depends on the length
> of the source argument [-Werror=stringop-overflow=]
> on src/dnsproxy.c:1794
Thank you Lukáš for your concern.
> I not sure if suppressing compiler warning is a good practice
> in Connman, but it fixes build for me :-)
In fact, the warning are useful to detect potential issues,
and normally you can trust them, so inhibiting them is a bad
practice.
Moreover, an overflow can lead to security issues,
so it shall be fixed instead of been ignored.
The better is to specify the correct size during the copy.
These kind of work (warning fixes on gcc update) is
usually done frequently by the team, the related commit
will probably appear soon, as it was done with
90f0e412569b327d8b25b834623b814f1fddbd19
& 3dbcc963a66d43e4ac51c97de4fe116ec72eb9f6).
Best Regards,
Emmanuel
next reply other threads:[~2021-06-15 9:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 9:51 VAUTRIN Emmanuel (Canal Plus Prestataire) [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-06-15 7:40 [PATCH] dnsproxy: Suppress GCC warning stringop-overflow Lukáš Karas
2021-06-15 9:15 ` Santtu Lakkala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PR1PR02MB479414C6FC276ADEE776118493309@PR1PR02MB4794.eurprd02.prod.outlook.com \
--to=emmanuel.vautrin@cpexterne.org \
--cc=connman@lists.linux.dev \
--cc=lukas.karas@centrum.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).