From: "VAUTRIN Emmanuel (Canal Plus Prestataire)" <Emmanuel.VAUTRIN@cpexterne.org>
To: Jussi Laakkonen <jussi.laakkonen@jolla.com>,
"connman@lists.linux.dev" <connman@lists.linux.dev>
Subject: RE: [PATCH] service: Fix preferred service reordering on ready state
Date: Tue, 15 Jun 2021 12:35:57 +0000 [thread overview]
Message-ID: <PR1PR02MB4794AE9D35473E527750BE1F93319@PR1PR02MB4794.eurprd02.prod.outlook.com> (raw)
In-Reply-To: <3213af74-2985-ada6-09d4-67d5ccf1f72f@jolla.com>
Hi Jussi,
> Wouldn't this be more simpler to be done service_compare() utilizing the
> PreferredTechnologies setting as I assume this is the issue you are
> trying to resolve:
As I said in the "[PATCH 0/1] start online check even if service is not
the default service" former thread, I have also worked on this issue,
and I presume the reason is not related to the reordering itself, but is
more a state update matter.
I let Daniel and Christophe Ronco test and check my changes carefully,
but I am pretty convinced that fixing the service_compare is not enough.
Best Regards,
Emmanuel
next prev parent reply other threads:[~2021-06-15 12:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 9:41 [PATCH] service: Fix preferred service reordering on ready state VAUTRIN Emmanuel (Canal Plus Prestataire)
2021-06-14 10:29 ` Jussi Laakkonen
2021-06-15 12:35 ` VAUTRIN Emmanuel (Canal Plus Prestataire) [this message]
2021-06-17 9:07 ` Jussi Laakkonen
2021-06-17 10:22 ` VAUTRIN Emmanuel (Canal Plus Prestataire)
2021-06-21 7:30 ` Daniel Wagner
2021-06-21 8:35 ` VAUTRIN Emmanuel (Canal Plus Prestataire)
2021-06-22 15:38 ` VAUTRIN Emmanuel (Canal Plus Prestataire)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PR1PR02MB4794AE9D35473E527750BE1F93319@PR1PR02MB4794.eurprd02.prod.outlook.com \
--to=emmanuel.vautrin@cpexterne.org \
--cc=connman@lists.linux.dev \
--cc=jussi.laakkonen@jolla.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).