Hi Daniel,

On Wed, May 25, 2022 at 09:01:46AM +0200, Daniel Wagner wrote:
> Though we need set the C standard to C99 I suppose:
> 
> 
> src/dnsproxy.c: In function ‘refresh_dns_entry’:
> src/dnsproxy.c:394:9: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
>   394 |         int age = 1;
>       |         ^~~

I will switch to AC_PROG_CC_C99 in autoconf, hopefully that is enough.

> and my compiler complained about a few things:
> 
> src/dnsproxy.c:410:25: error: comparison of integer expressions of different signedness: ‘size_t’ {aka ‘long unsigned int’} and ‘int’ [-Werror=sign-compare]
>   410 |         if (entry->hits > age)

I used a slightly older GCC for the patches, the next round will have
them fixed, hopefully.

> BTW, since this contribution is major I would suggest you add your
> copyright statement to the file as well.

Will do, although it feels a bit weird to me ;-)

Cheers

Matthias