* RE: [PATCH] iwd: Mark only reachable networks as available
[not found] <20220118125207.1204244-1-Emmanuel.VAUTRIN@cpexterne.org>
@ 2022-01-18 12:56 ` VAUTRIN Emmanuel (Canal Plus Prestataire)
2022-01-21 7:54 ` Daniel Wagner
0 siblings, 1 reply; 5+ messages in thread
From: VAUTRIN Emmanuel (Canal Plus Prestataire) @ 2022-01-18 12:56 UTC (permalink / raw)
To: connman
[-- Attachment #1: Type: text/plain, Size: 811 bytes --]
Only reachable networks, with a significant signal strength, shall be
marked as available.
---
plugins/iwd.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/plugins/iwd.c b/plugins/iwd.c
index b0e17a4d6396..a17e9c35398b 100644
--- a/plugins/iwd.c
+++ b/plugins/iwd.c
@@ -943,7 +943,9 @@ static void add_network(const char *path, struct iwd_network *iwdn)
}
iwdn->iwdd = iwdd;
- connman_network_set_available(iwdn->network, true);
+ if (connman_network_get_strength(iwdn->network))
+ connman_network_set_available(iwdn->network, true);
+
connman_network_set_group(iwdn->network, identifier);
g_free(identifier);
--
2.25.1
Hi,
Please find the right formatted patch as attached file.
Emmanuel
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-iwd-Mark-only-reachable-networks-as-available.patch --]
[-- Type: text/x-patch; name="0001-iwd-Mark-only-reachable-networks-as-available.patch", Size: 890 bytes --]
From 3cf7c7d2cc230b013f970c398763875469769472 Mon Sep 17 00:00:00 2001
From: Emmanuel VAUTRIN <Emmanuel.VAUTRIN@cpexterne.org>
Date: Tue, 11 Jan 2022 14:08:26 +0100
Subject: [PATCH] iwd: Mark only reachable networks as available
Only reachable networks, with a significant signal strength, shall be
marked as available.
---
plugins/iwd.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/plugins/iwd.c b/plugins/iwd.c
index b0e17a4d6396..a17e9c35398b 100644
--- a/plugins/iwd.c
+++ b/plugins/iwd.c
@@ -943,7 +943,9 @@ static void add_network(const char *path, struct iwd_network *iwdn)
}
iwdn->iwdd = iwdd;
- connman_network_set_available(iwdn->network, true);
+ if (connman_network_get_strength(iwdn->network))
+ connman_network_set_available(iwdn->network, true);
+
connman_network_set_group(iwdn->network, identifier);
g_free(identifier);
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] iwd: Mark only reachable networks as available
2022-01-18 12:56 ` [PATCH] iwd: Mark only reachable networks as available VAUTRIN Emmanuel (Canal Plus Prestataire)
@ 2022-01-21 7:54 ` Daniel Wagner
2022-01-21 9:43 ` VAUTRIN Emmanuel (Canal Plus Prestataire)
0 siblings, 1 reply; 5+ messages in thread
From: Daniel Wagner @ 2022-01-21 7:54 UTC (permalink / raw)
To: VAUTRIN Emmanuel (Canal Plus Prestataire); +Cc: connman
On Tue, Jan 18, 2022 at 12:56:30PM +0000, VAUTRIN Emmanuel (Canal Plus Prestataire) wrote:
> Only reachable networks, with a significant signal strength, shall be
> marked as available.
Patch applied. I was not aware that iwd shows networks with no signal
strength. Thanks!
Daniel
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] iwd: Mark only reachable networks as available
2022-01-21 7:54 ` Daniel Wagner
@ 2022-01-21 9:43 ` VAUTRIN Emmanuel (Canal Plus Prestataire)
2022-01-23 13:14 ` Daniel Wagner
0 siblings, 1 reply; 5+ messages in thread
From: VAUTRIN Emmanuel (Canal Plus Prestataire) @ 2022-01-21 9:43 UTC (permalink / raw)
To: connman
> Patch applied. I was not aware that iwd shows networks with no signal
> strength. Thanks!
Great news, thank you Daniel!
Indeed, it is really rare, but I have noticed that during some full test
campaigns, what I have never noticed (during years) with wpa-supplicant.
Best Regards,
Emmanuel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] iwd: Mark only reachable networks as available
2022-01-21 9:43 ` VAUTRIN Emmanuel (Canal Plus Prestataire)
@ 2022-01-23 13:14 ` Daniel Wagner
2022-01-24 21:54 ` James Prestwood
0 siblings, 1 reply; 5+ messages in thread
From: Daniel Wagner @ 2022-01-23 13:14 UTC (permalink / raw)
To: VAUTRIN Emmanuel (Canal Plus Prestataire); +Cc: connman, iwd
On Fri, Jan 21, 2022 at 09:43:04AM +0000, VAUTRIN Emmanuel (Canal Plus Prestataire) wrote:
> > Patch applied. I was not aware that iwd shows networks with no signal
> > strength. Thanks!
>
> Great news, thank you Daniel!
> Indeed, it is really rare, but I have noticed that during some full test
> campaigns, what I have never noticed (during years) with wpa-supplicant.
Alright, let's add the iwd mailing list. Maybe it's a bug, no idea.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] iwd: Mark only reachable networks as available
2022-01-23 13:14 ` Daniel Wagner
@ 2022-01-24 21:54 ` James Prestwood
0 siblings, 0 replies; 5+ messages in thread
From: James Prestwood @ 2022-01-24 21:54 UTC (permalink / raw)
To: Daniel Wagner, VAUTRIN Emmanuel (Canal Plus Prestataire); +Cc: connman, iwd
On Sun, 2022-01-23 at 14:14 +0100, Daniel Wagner wrote:
> On Fri, Jan 21, 2022 at 09:43:04AM +0000, VAUTRIN Emmanuel (Canal
> Plus Prestataire) wrote:
> > > Patch applied. I was not aware that iwd shows networks with no
> > > signal
> > > strength. Thanks!
> >
> > Great news, thank you Daniel!
> > Indeed, it is really rare, but I have noticed that during some full
> > test
> > campaigns, what I have never noticed (during years) with wpa-
> > supplicant.
>
> Alright, let's add the iwd mailing list. Maybe it's a bug, no idea.
I only see one way this could happen, with a select few drivers.
Looks like the kernel has two possible attributes for the signal
stength based on what the driver sets 'signal_type' to. IWD only
handles SIGNAL_DBM, but SIGNAL_UNSPEC is also possible.
What hardware did you see this on? Based on what I'm seeing in the
kernel it is probably one of zd1211rw, at76c50x-usb, adm8211, or
rtl8180?
I'm gonna guess this never got handled because the nl80211 docs say
this attribute is "unspecified units"...
Thanks,
James
> _______________________________________________
> iwd mailing list -- iwd@lists.01.org
> To unsubscribe send an email to iwd-leave@lists.01.org
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-01-24 21:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20220118125207.1204244-1-Emmanuel.VAUTRIN@cpexterne.org>
2022-01-18 12:56 ` [PATCH] iwd: Mark only reachable networks as available VAUTRIN Emmanuel (Canal Plus Prestataire)
2022-01-21 7:54 ` Daniel Wagner
2022-01-21 9:43 ` VAUTRIN Emmanuel (Canal Plus Prestataire)
2022-01-23 13:14 ` Daniel Wagner
2022-01-24 21:54 ` James Prestwood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).