From: Alexey Gladkov <email@example.com> To: Linus Torvalds <firstname.lastname@example.org> Cc: "Eric W. Biederman" <email@example.com>, Linux Kernel Mailing List <firstname.lastname@example.org>, Linux Containers <email@example.com> Subject: Re: [GIT PULL] ucounts: Count rlimits in each user namespace Date: Tue, 29 Jun 2021 23:22:20 +0200 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <CAHk-=wjQks3o_3=WewaXw++h+a318B3LTLSFER9Ee4n1pLCZLw@mail.gmail.com> On Tue, Jun 29, 2021 at 01:33:39PM -0700, Linus Torvalds wrote: > On Tue, Jun 29, 2021 at 1:20 PM Alexey Gladkov <email@example.com> wrote: > > > > Waaaait. task_ucounts() is a different thing. This function only gets a > > field from the task structure without any reference counting. But the > > get_ucounts() is more like get_user_ns() or get_uid(), but does not ignore > > counter overflow. > > Alexey, that code cannot be right. > > Look here: > > rcu_read_lock(); > ucounts = task_ucounts(t); > sigpending = inc_rlimit_ucounts(ucounts, UCOUNT_RLIMIT_SIGPENDING, 1); > if (sigpending == 1) > ucounts = get_ucounts(ucounts); > rcu_read_unlock(); > > so now we've done that inc_rlimit_ucounts() unconditionally on that > task_ucounts() thing. > > And then if the allocation fails (or the limit is hit) the code does > > if (ucounts && dec_rlimit_ucounts(ucounts, UCOUNT_RLIMIT_SIGPENDING, 1)) > put_ucounts(ucounts); > > ie now it does the dec_rlimit_ucounts _conditionally_. > > See what I'm complaining about? This is not logical, AND IT CANNOT > POSSIBLY BE RIGHT. > > My argument is that > > (a) the dec_rlimit_ucounts() has to pair up with > inc_rlimit_ucounts(), or you're leaking counts > > (b) get_ucounts() has to pair up with put_ucounts(). > > Note that (a) has to be REGARDLESS of whether get_ucounts() was > successful or not. > > > Earlier I tried to use refcount_t which never returns errors . We > > talked and you said that ignoring counter overflow errors is bad > > design for this case. > > You can't ignore counter overflow errors, no. But that's exactly what > that code is doing. > > If get_ucount() fails due to overflow, you don't return an error. You > just miscount the end result! > > So yeah, its' "testing" the overflow condition, but that's not an > argument, when it then DOES EXPLICITLY THE WRONG THING. > > At that point, the test is actively harmful and wrong. See? Yes. Please, give me some time to fix it. -- Rgrds, legion
next prev parent reply other threads:[~2021-06-29 21:22 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-28 22:35 Eric W. Biederman 2021-06-29 3:47 ` Linus Torvalds 2021-06-29 15:04 ` Eric W. Biederman 2021-06-29 15:51 ` Eric W. Biederman 2021-06-29 16:34 ` Linus Torvalds 2021-06-29 16:42 ` Eric W. Biederman 2021-06-29 17:09 ` Eric W. Biederman 2021-07-01 16:41 ` Alexey Gladkov 2021-07-01 20:05 ` Eric W. Biederman 2021-06-29 17:17 ` Alexey Gladkov 2021-06-29 18:07 ` Linus Torvalds 2021-06-29 20:20 ` Alexey Gladkov 2021-06-29 20:33 ` Linus Torvalds 2021-06-29 21:22 ` Alexey Gladkov [this message] 2021-07-02 17:54 ` [PATCH] ucounts: Fix UCOUNT_RLIMIT_SIGPENDING counter leak Alexey Gladkov 2021-07-02 22:13 ` Linus Torvalds 2021-07-07 16:50 ` Alexey Gladkov 2021-07-07 17:23 ` Linus Torvalds 2021-07-08 10:33 ` [PATCH v2] " Alexey Gladkov 2021-07-08 18:44 ` Linus Torvalds 2021-07-08 11:00 ` [PATCH] ucounts: " Alexey Gladkov 2021-06-29 3:50 ` [GIT PULL] ucounts: Count rlimits in each user namespace pr-tracker-bot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [GIT PULL] ucounts: Count rlimits in each user namespace' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).